Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Add tr to skybox types
  • Loading branch information
NEDJIMAbelgacem committed Aug 6, 2020
1 parent 02d94be commit 736b3e6
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions src/app/3d/qgsskyboxrenderingsettingswidget.cpp
Expand Up @@ -27,15 +27,15 @@ QgsSkyboxRenderingSettingsWidget::QgsSkyboxRenderingSettingsWidget( QWidget *par
layoutGroupBoxes.push_back( panoramicTextureGroupBox );
layoutGroupBoxes.push_back( faceTexturesGroupBox );

skyboxTypeComboBox->addItem( QStringLiteral( "Panoramic texture" ) );
skyboxTypeComboBox->addItem( QStringLiteral( "Distinct Faces" ) );
skyboxTypeComboBox->addItem( tr( "Panoramic texture" ) );
skyboxTypeComboBox->addItem( tr( "Distinct Faces" ) );
connect( skyboxTypeComboBox, &QComboBox::currentTextChanged, [&]( const QString & skyboxType )
{
for ( QGroupBox *groupBox : layoutGroupBoxes )
groupBox->setVisible( false );
if ( skyboxType == QStringLiteral( "Panoramic texture" ) )
if ( skyboxType == tr( "Panoramic texture" ) )
panoramicTextureGroupBox->setVisible( true );
if ( skyboxType == QStringLiteral( "Distinct Faces" ) )
if ( skyboxType == tr( "Distinct Faces" ) )
faceTexturesGroupBox->setVisible( true );
} );
skyboxTypeComboBox->setCurrentIndex( 1 );
Expand All @@ -47,11 +47,11 @@ void QgsSkyboxRenderingSettingsWidget::setSkyboxSettings( const QgsSkyboxSetting

switch ( skyboxSettings.skyboxType() )
{
case QgsSkyboxEntity::DistinctTexturesSkybox:
skyboxTypeComboBox->setCurrentText( QStringLiteral( "Distinct Faces" ) );
break;
case QgsSkyboxEntity::PanoramicSkybox:
skyboxTypeComboBox->setCurrentText( QStringLiteral( "Panoramic texture" ) );
skyboxTypeComboBox->setCurrentText( tr( "Panoramic texture" ) );
break;
case QgsSkyboxEntity::DistinctTexturesSkybox:
skyboxTypeComboBox->setCurrentText( tr( "Distinct Faces" ) );
break;
}

Expand All @@ -70,10 +70,10 @@ QgsSkyboxSettings QgsSkyboxRenderingSettingsWidget::toSkyboxSettings()
QgsSkyboxSettings settings;
settings.setIsSkyboxEnabled( skyboxEnabledCheckBox->checkState() == Qt::CheckState::Checked );

if ( skyboxTypeComboBox->currentText() == QStringLiteral( "Distinct Faces" ) )
settings.setSkyboxType( QgsSkyboxEntity::DistinctTexturesSkybox );
else if ( skyboxTypeComboBox->currentText() == QStringLiteral( "Panoramic texture" ) )
if ( skyboxTypeComboBox->currentText() == tr( "Panoramic texture" ) )
settings.setSkyboxType( QgsSkyboxEntity::PanoramicSkybox );
else if ( skyboxTypeComboBox->currentText() == tr( "Distinct Faces" ) )
settings.setSkyboxType( QgsSkyboxEntity::DistinctTexturesSkybox );

settings.setPanoramicTexturePath( panoramicTextureImageSource->source() );
settings.setCubeMapFace( QStringLiteral( "posX" ), posXImageSource->source() );
Expand Down

0 comments on commit 736b3e6

Please sign in to comment.