Avoid heap allocations

nyalldawson · nyalldawson · commit 728b9fcf9b8a · 2018-10-25T19:53:01.000+10:00
diff --git a/src/app/qgisappstylesheet.cpp b/src/app/qgisappstylesheet.cpp
@@ -68,13 +68,12 @@ QMap<QString, QVariant> QgisAppStyleSheet::defaultOptions()
   // make sure family exists on system
   if ( fontFamily != mDefaultFont.family() )
   {
-    QFont *tempFont = new QFont( fontFamily );
-    if ( tempFont->family() != fontFamily )
+    QFont tempFont( fontFamily );
+    if ( tempFont.family() != fontFamily )
     {
       // missing from system, drop back to default
       fontFamily = mDefaultFont.family();
     }
-    delete tempFont;
   }
   QgsDebugMsg( QStringLiteral( "fontFamily: %1" ).arg( fontFamily ) );
   opts.insert( QStringLiteral( "fontFamily" ), QVariant( fontFamily ) );

Original file line number	Diff line number	Diff line change
`@@ -68,13 +68,12 @@ QMap<QString, QVariant> QgisAppStyleSheet::defaultOptions()`
`68`	`68`	`// make sure family exists on system`
`69`	`69`	`if ( fontFamily != mDefaultFont.family() )`
`70`	`70`	`{`
`71`		`- QFont *tempFont = new QFont( fontFamily );`
`72`		`- if ( tempFont->family() != fontFamily )`
	`71`	`+ QFont tempFont( fontFamily );`
	`72`	`+ if ( tempFont.family() != fontFamily )`
`73`	`73`	`{`
`74`	`74`	`// missing from system, drop back to default`
`75`	`75`	`fontFamily = mDefaultFont.family();`
`76`	`76`	`}`
`77`		`- delete tempFont;`
`78`	`77`	`}`
`79`	`78`	`QgsDebugMsg( QStringLiteral( "fontFamily: %1" ).arg( fontFamily ) );`
`80`	`79`	`opts.insert( QStringLiteral( "fontFamily" ), QVariant( fontFamily ) );`