Skip to content

Commit 71fbe9c

Browse files
committedOct 19, 2014
[composer] Fixes to composer item sip bindings
- Added some missing /TransferThis/ arguments - Ensure that correct item type is returned for all item types
1 parent c1b63df commit 71fbe9c

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed
 

‎python/core/composer/qgscomposerframe.sip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class QgsComposerFrame: QgsComposerItem
66
%End
77

88
public:
9-
QgsComposerFrame( QgsComposition* c, QgsComposerMultiFrame* mf, qreal x, qreal y, qreal width, qreal height );
9+
QgsComposerFrame( QgsComposition* c /TransferThis/, QgsComposerMultiFrame* mf, qreal x, qreal y, qreal width, qreal height );
1010
~QgsComposerFrame();
1111

1212
/**Sets the visible part of the multiframe's content which is visible within

‎python/core/composer/qgscomposeritem.sip

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ class QgsComposerItem : QgsComposerObject, QGraphicsRectItem
55
{
66
%TypeHeaderCode
77
#include <qgscomposeritem.h>
8+
#include <qgscomposerarrow.h>
9+
#include <qgscomposerframe.h>
10+
#include <qgscomposeritemgroup.h>
811
#include <qgscomposerlabel.h>
912
#include <qgscomposerlegend.h>
1013
#include <qgscomposermap.h>
@@ -13,6 +16,7 @@ class QgsComposerItem : QgsComposerObject, QGraphicsRectItem
1316
#include <qgscomposerscalebar.h>
1417
#include <qgscomposershape.h>
1518
#include <qgscomposertable.h>
19+
#include <qgscomposertexttable.h>
1620
#include <qgscomposerattributetable.h>
1721
%End
1822

@@ -25,16 +29,14 @@ class QgsComposerItem : QgsComposerObject, QGraphicsRectItem
2529
sipClass = sipClass_QgsComposerItem;
2630
*sipCppRet = static_cast<QgsComposerItem*>(sipCpp);
2731
break;
28-
#if 0
2932
case QgsComposerItem::ComposerArrow:
3033
sipClass = sipClass_QgsComposerArrow;
3134
*sipCppRet = static_cast<QgsComposerArrow*>(sipCpp);
32-
break;
35+
break;
3336
case QgsComposerItem::ComposerItemGroup:
3437
sipClass = sipClass_QgsComposerItemGroup;
3538
*sipCppRet = static_cast<QgsComposerItemGroup*>(sipCpp);
3639
break;
37-
#endif
3840
case QgsComposerItem::ComposerLabel:
3941
sipClass = sipClass_QgsComposerLabel;
4042
*sipCppRet = static_cast<QgsComposerLabel*>(sipCpp);
@@ -71,12 +73,14 @@ class QgsComposerItem : QgsComposerObject, QGraphicsRectItem
7173
sipClass = sipClass_QgsComposerAttributeTable;
7274
*sipCppRet = static_cast<QgsComposerAttributeTable*>(sipCpp);
7375
break;
74-
/*
7576
case QgsComposerItem::ComposerTextTable:
7677
sipClass = sipClass_QgsComposerTextTable;
7778
*sipCppRet = static_cast<QgsComposerTextTable*>(sipCpp);
7879
break;
79-
*/
80+
case QgsComposerItem::ComposerFrame:
81+
sipClass = sipClass_QgsComposerFrame;
82+
*sipCppRet = static_cast<QgsComposerFrame*>(sipCpp);
83+
break;
8084
default:
8185
sipClass = 0;
8286
}

‎python/core/composer/qgscomposeritemgroup.sip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ class QgsComposerItemGroup: QgsComposerItem
44
#include <qgscomposeritemgroup.h>
55
%End
66
public:
7-
QgsComposerItemGroup( QgsComposition* c );
7+
QgsComposerItemGroup( QgsComposition* c /TransferThis/ );
88
~QgsComposerItemGroup();
99

1010
/** return correct graphics item type. Added in v1.7 */

0 commit comments

Comments
 (0)
Please sign in to comment.