Avoid spurious cpp check function can be const warning

nyalldawson · nyalldawson · commit 6fca53cdf1dd · 2023-04-10T10:42:31.000+10:00
diff --git a/src/gui/qgsproviderguiregistry.cpp b/src/gui/qgsproviderguiregistry.cpp
@@ -219,11 +219,9 @@ QgsProviderGuiRegistry::~QgsProviderGuiRegistry()
 
 void QgsProviderGuiRegistry::registerGuis( QMainWindow *parent )
 {
-  GuiProviders::const_iterator it = mProviders.begin();
-  while ( it != mProviders.end() )
+  for ( auto it = mProviders.begin(); it != mProviders.end(); ++it )
   {
     it->second->registerGui( parent );
-    ++it;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -219,11 +219,9 @@ QgsProviderGuiRegistry::~QgsProviderGuiRegistry()`
`219`	`219`
`220`	`220`	`void QgsProviderGuiRegistry::registerGuis( QMainWindow *parent )`
`221`	`221`	`{`
`222`		`- GuiProviders::const_iterator it = mProviders.begin();`
`223`		`- while ( it != mProviders.end() )`
	`222`	`+ for ( auto it = mProviders.begin(); it != mProviders.end(); ++it )`
`224`	`223`	`{`
`225`	`224`	`it->second->registerGui( parent );`
`226`		`- ++it;`
`227`	`225`	`}`
`228`	`226`	`}`
`229`	`227`