updateProperties function private and no reference for currentFormFea…

…ture
qgis · Aug 17, 2020 · 6fbeb47 · 6fbeb47
1 parent 6be231b
commit 6fbeb47
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/python/gui/auto_generated/qgsattributeform.sip.in b/python/gui/auto_generated/qgsattributeform.sip.in
@@ -44,7 +44,7 @@ class QgsAttributeForm : QWidget
 
     const QgsFeature &feature();
 
-    const QgsFeature &currentFormFeature();
+    QgsFeature currentFormFeature() const;
 %Docstring
 Returns the feature that is currently displayed in the form with all
 the changes received on editing the values in the widgets.

diff --git a/python/gui/auto_generated/qgsexternalresourcewidget.sip.in b/python/gui/auto_generated/qgsexternalresourcewidget.sip.in
@@ -138,6 +138,7 @@ is set to QgsFileWidget.RelativeDefaultPath.
     void reloadDocument();
 %Docstring
 Reloads the document from the path of the filewidget
+/since QGIS 3.16
 %End
 
   signals:

diff --git a/src/gui/editorwidgets/qgsexternalresourcewidgetwrapper.h b/src/gui/editorwidgets/qgsexternalresourcewidgetwrapper.h
@@ -59,7 +59,6 @@ class GUI_EXPORT QgsExternalResourceWidgetWrapper : public QgsEditorWidgetWrappe
   public:
     QVariant value() const override;
     void showIndeterminateState() override;
-    void updateProperties( const QgsFeature &feature );
 
   protected:
     QWidget *createWidget( QWidget *parent ) override;
@@ -85,6 +84,7 @@ class GUI_EXPORT QgsExternalResourceWidgetWrapper : public QgsEditorWidgetWrappe
   private:
     void updateValues( const QVariant &value, const QVariantList & = QVariantList() ) override;
     void updateConstraintWidgetStatus() override;
+    void updateProperties( const QgsFeature &feature );
 
     QLineEdit *mLineEdit = nullptr;
     QLabel *mLabel = nullptr;

diff --git a/src/gui/qgsattributeform.h b/src/gui/qgsattributeform.h
@@ -81,7 +81,7 @@ class GUI_EXPORT QgsAttributeForm : public QWidget
      *
      * \since QGIS 3.16
      */
-    const QgsFeature &currentFormFeature() { return mCurrentFormFeature; }
+    QgsFeature currentFormFeature() const { return mCurrentFormFeature; }
 
     /**
      * Displays a warning message in the form message bar

diff --git a/src/gui/qgsexternalresourcewidget.h b/src/gui/qgsexternalresourcewidget.h
@@ -145,6 +145,7 @@ class GUI_EXPORT QgsExternalResourceWidget : public QWidget
 
     /**
      * Reloads the document from the path of the filewidget
+     * /since QGIS 3.16
      */
     void reloadDocument();