better a static list to avoid set at every call

luipir · luipir · commit 6ea9ff07134b · 2019-02-12T10:18:24.000+01:00
diff --git a/src/core/raster/qgsmultibandcolorrenderer.cpp b/src/core/raster/qgsmultibandcolorrenderer.cpp
@@ -507,8 +507,7 @@ void QgsMultiBandColorRenderer::toSld( QDomDocument &doc, QDomElement &element,
   }
 
   // for each mapped band
-  QStringList tags;
-  tags << QStringLiteral( "sld:RedChannel" ) << QStringLiteral( "sld:GreenChannel" ) << QStringLiteral( "sld:BlueChannel" );
+  static QStringList tags { QStringLiteral( "sld:RedChannel" ), QStringLiteral( "sld:GreenChannel" ), QStringLiteral( "sld:BlueChannel" ) };
 
   QList<QgsContrastEnhancement *> contrastEnhancements;
   contrastEnhancements.append( mRedContrastEnhancement );

Original file line number	Diff line number	Diff line change
`@@ -507,8 +507,7 @@ void QgsMultiBandColorRenderer::toSld( QDomDocument &doc, QDomElement &element,`
`507`	`507`	`}`
`508`	`508`
`509`	`509`	`// for each mapped band`
`510`		`- QStringList tags;`
`511`		`- tags << QStringLiteral( "sld:RedChannel" ) << QStringLiteral( "sld:GreenChannel" ) << QStringLiteral( "sld:BlueChannel" );`
	`510`	`+ static QStringList tags { QStringLiteral( "sld:RedChannel" ), QStringLiteral( "sld:GreenChannel" ), QStringLiteral( "sld:BlueChannel" ) };`
`512`	`511`
`513`	`512`	`QList<QgsContrastEnhancement *> contrastEnhancements;`
`514`	`513`	`contrastEnhancements.append( mRedContrastEnhancement );`