Skip to content

Commit

Permalink
Fix clazy missing/invalid emit warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Feb 2, 2018
1 parent f0b14c5 commit 6e7a995
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/app/qgsbookmarks.cpp
Expand Up @@ -727,7 +727,7 @@ bool QgsMergedBookmarksTableModel::projectAvailable() const

void QgsMergedBookmarksTableModel::moveBookmark( QAbstractTableModel &modelFrom, QAbstractTableModel &modelTo, int row )
{
emit beginResetModel();
beginResetModel();
QSqlTableModel *qgisModel = dynamic_cast<QSqlTableModel *>( &modelTo );
if ( !qgisModel )
{
Expand Down Expand Up @@ -765,7 +765,7 @@ void QgsMergedBookmarksTableModel::moveBookmark( QAbstractTableModel &modelFrom,
qgisModel->select();
modelFrom.removeRows( row, 1 );
}
emit endResetModel();
endResetModel();
emit layoutChanged();
}

Expand Down
2 changes: 1 addition & 1 deletion src/gui/editorwidgets/qgsexternalresourcewidgetwrapper.cpp
Expand Up @@ -207,7 +207,7 @@ void QgsExternalResourceWidgetWrapper::setValue( const QVariant &value )
if ( mLabel )
{
mLabel->setText( value.toString() );
valueChanged( value.toString() ); // emit signal that value has changed, do not do it for other widgets
emit valueChanged( value.toString() ); // emit signal that value has changed, do not do it for other widgets
}

if ( mQgsWidget )
Expand Down
4 changes: 2 additions & 2 deletions src/gui/editorwidgets/qgsrangewidgetwrapper.cpp
Expand Up @@ -169,9 +169,9 @@ bool QgsRangeWidgetWrapper::valid() const
void QgsRangeWidgetWrapper::valueChangedVariant( const QVariant &v )
{
if ( v.type() == QVariant::Int )
valueChanged( v.toInt() );
emit valueChanged( v.toInt() );
if ( v.type() == QVariant::Double )
valueChanged( v.toDouble() );
emit valueChanged( v.toDouble() );
}

QVariant QgsRangeWidgetWrapper::value() const
Expand Down

0 comments on commit 6e7a995

Please sign in to comment.