[layouts] Fix crash on report section delete

nyalldawson · nyalldawson · commit 6e2e0732f51b · 2018-08-13T11:09:00.000+10:00
Fixes #19447
diff --git a/src/gui/layout/qgslayoutview.cpp b/src/gui/layout/qgslayoutview.cpp
@@ -92,21 +92,17 @@ void QgsLayoutView::setCurrentLayout( QgsLayout *layout )
 
   viewChanged();
 
-  delete mSnapMarker;
+  // IMPORTANT!
+  // previous snap markers, snap lines are owned by previous layout - so don't delete them here!
   mSnapMarker = new QgsLayoutViewSnapMarker();
   mSnapMarker->hide();
   layout->addItem( mSnapMarker );
-
-  delete mHorizontalSnapLine;
   mHorizontalSnapLine = createSnapLine();
   mHorizontalSnapLine->hide();
   layout->addItem( mHorizontalSnapLine );
-  delete mVerticalSnapLine;
   mVerticalSnapLine = createSnapLine();
   mVerticalSnapLine->hide();
   layout->addItem( mVerticalSnapLine );
-
-  delete mSectionLabel;
   mSectionLabel = nullptr;
 
   if ( mHorizontalRuler )
