enable Toggle editing button depending on layer type (fix #4965)

alexbruy · alexbruy · commit 6e1e55e41615 · 2012-02-19T09:48:06.000+02:00
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -5734,9 +5734,10 @@ void QgisApp::activateDeactivateLayerRelatedActions( QgsMapLayer* layer )
       //start editing/stop editing
       if ( dprovider->capabilities() & QgsVectorDataProvider::EditingCapabilities )
       {
-        mActionToggleEditing->setEnabled( !vlayer->isReadOnly() );
+        bool canChangeAttributes = dprovider->capabilities() & QgsVectorDataProvider::ChangeAttributeValues;
+        mActionToggleEditing->setEnabled( canChangeAttributes && !vlayer->isReadOnly() );
         mActionToggleEditing->setChecked( vlayer->isEditable() );
-        mActionSaveEdits->setEnabled( vlayer->isEditable() );
+        mActionSaveEdits->setEnabled( canChangeAttributes && vlayer->isEditable() );
       }
       else
       {

Original file line number	Diff line number	Diff line change
`@@ -5734,9 +5734,10 @@ void QgisApp::activateDeactivateLayerRelatedActions( QgsMapLayer* layer )`
`5734`	`5734`	`//start editing/stop editing`
`5735`	`5735`	`if ( dprovider->capabilities() & QgsVectorDataProvider::EditingCapabilities )`
`5736`	`5736`	`{`
`5737`		`- mActionToggleEditing->setEnabled( !vlayer->isReadOnly() );`
	`5737`	`+ bool canChangeAttributes = dprovider->capabilities() & QgsVectorDataProvider::ChangeAttributeValues;`
	`5738`	`+ mActionToggleEditing->setEnabled( canChangeAttributes && !vlayer->isReadOnly() );`
`5738`	`5739`	`mActionToggleEditing->setChecked( vlayer->isEditable() );`
`5739`		`- mActionSaveEdits->setEnabled( vlayer->isEditable() );`
	`5740`	`+ mActionSaveEdits->setEnabled( canChangeAttributes && vlayer->isEditable() );`
`5740`	`5741`	`}`
`5741`	`5742`	`else`
`5742`	`5743`	`{`