Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Cleanup QgsVectorLayer::geometryType()
The method QgsVectorLayer::wkbType() already uses a member variable which is a copy
of the one on the data provider. By using this, the code becomes simpler and more
consistent.

(cherry picked from commit bc6a9c5)
  • Loading branch information
m-kuhn authored and nyalldawson committed Mar 5, 2019
1 parent bae156e commit 6e1b91f
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions src/core/qgsvectorlayer.cpp
Expand Up @@ -588,16 +588,7 @@ void QgsVectorLayer::setDiagramRenderer( QgsDiagramRenderer *r )

QgsWkbTypes::GeometryType QgsVectorLayer::geometryType() const
{
if ( mValid && mDataProvider )
{
return QgsWkbTypes::geometryType( mDataProvider->wkbType() );
}
else
{
QgsDebugMsgLevel( QStringLiteral( "invalid layer or pointer to mDataProvider is null" ), 3 );
}
QgsDebugMsgLevel( QStringLiteral( "Vector layer with unknown geometry type." ), 3 );
return QgsWkbTypes::UnknownGeometry;
return QgsWkbTypes::geometryType( mWkbType );
}

QgsWkbTypes::Type QgsVectorLayer::wkbType() const
Expand Down

0 comments on commit 6e1b91f

Please sign in to comment.