QgsVectorLayerFeaturePool needs to be aware of geometry changes

m-kuhn · m-kuhn · commit 6df73d6d0729 · 2018-10-15T14:28:03.000+02:00
diff --git a/python/analysis/auto_generated/vector/geometry_checker/qgsfeaturepool.sip.in b/python/analysis/auto_generated/vector/geometry_checker/qgsfeaturepool.sip.in
@@ -90,6 +90,7 @@ To be used by implementations of ``deleteFeature``.
 %End
 
 
+
   private:
     QgsFeaturePool( const QgsFeaturePool &other );
 };
diff --git a/src/analysis/CMakeLists.txt b/src/analysis/CMakeLists.txt
@@ -186,6 +186,7 @@ SET(QGIS_ANALYSIS_MOC_HDRS
 
   vector/geometry_checker/qgsgeometrychecker.h
   vector/geometry_checker/qgsgeometrycheck.h
+  vector/geometry_checker/qgsvectorlayerfeaturepool.h
 )
 
 INCLUDE_DIRECTORIES(SYSTEM ${SPATIALITE_INCLUDE_DIR})
@@ -252,7 +253,6 @@ SET(QGIS_ANALYSIS_HDRS
   vector/geometry_checker/qgsgeometrycheckerutils.h
   vector/geometry_checker/qgsfeaturepool.h
   vector/geometry_checker/qgsvectordataproviderfeaturepool.h
-  vector/geometry_checker/qgsvectorlayerfeaturepool.h
 
   interpolation/qgsinterpolator.h
   interpolation/qgsgridfilewriter.h
diff --git a/src/analysis/vector/geometry_checker/qgsfeaturepool.cpp b/src/analysis/vector/geometry_checker/qgsfeaturepool.cpp
@@ -140,6 +140,11 @@ void QgsFeaturePool::setFeatureIds( const QgsFeatureIds &ids )
   mFeatureIds = ids;
 }
 
+bool QgsFeaturePool::isFeatureCached( QgsFeatureId fid )
+{
+  return mFeatureCache.contains( fid );
+}
+
 QgsCoordinateReferenceSystem QgsFeaturePool::crs() const
 {
   return mCrs;
diff --git a/src/analysis/vector/geometry_checker/qgsfeaturepool.h b/src/analysis/vector/geometry_checker/qgsfeaturepool.h
@@ -145,6 +145,14 @@ class ANALYSIS_EXPORT QgsFeaturePool : public QgsFeatureSink SIP_ABSTRACT
      */
     void setFeatureIds( const QgsFeatureIds &ids ) SIP_SKIP;
 
+    /**
+     * Checks if the feature \a fid is cached.
+     *
+     * \since QGIS 3.4
+     * \note not available in Python bindings
+     */
+    bool isFeatureCached( QgsFeatureId fid ) SIP_SKIP;
+
   private:
 #ifdef SIP_RUN
     QgsFeaturePool( const QgsFeaturePool &other )
diff --git a/src/analysis/vector/geometry_checker/qgsvectorlayerfeaturepool.cpp b/src/analysis/vector/geometry_checker/qgsvectorlayerfeaturepool.cpp
@@ -17,29 +17,14 @@ email                : matthias@opengis.ch
 #include "qgsthreadingutils.h"
 
 #include "qgsfeaturerequest.h"
+#include "qgsvectorlayer.h"
 
 QgsVectorLayerFeaturePool::QgsVectorLayerFeaturePool( QgsVectorLayer *layer )
-  : QgsFeaturePool( layer )
+  : QObject()
+  , QgsFeaturePool( layer )
 {
-  // Build spatial index
-  QgsFeature feature;
-  QgsFeatureRequest req;
-  QgsFeatureIds featureIds;
-
-  QgsFeatureIterator it = layer->getFeatures( req );
-  while ( it.nextFeature( feature ) )
-  {
-    if ( feature.geometry() )
-    {
-      insertFeature( feature );
-      featureIds.insert( feature.id() );
-    }
-    else
-    {
-      featureIds.remove( feature.id() );
-    }
-  }
-  setFeatureIds( featureIds );
+  connect( layer, &QgsVectorLayer::featureDeleted, this, &QgsVectorLayerFeaturePool::onFeatureDeleted );
+  connect( layer, &QgsVectorLayer::geometryChanged, this, &QgsVectorLayerFeaturePool::onGeometryChanged );
 }
 
 bool QgsVectorLayerFeaturePool::addFeature( QgsFeature &feature, Flags flags )
@@ -147,3 +132,19 @@ void QgsVectorLayerFeaturePool::deleteFeature( QgsFeatureId fid )
     }
   } );
 }
+
+void QgsVectorLayerFeaturePool::onGeometryChanged( QgsFeatureId fid, const QgsGeometry &geometry )
+{
+  if ( isFeatureCached( fid ) )
+  {
+    QgsFeature feature;
+    getFeature( fid, feature );
+    feature.setGeometry( geometry );
+    updateFeature( feature );
+  }
+}
+
+void QgsVectorLayerFeaturePool::onFeatureDeleted( QgsFeatureId fid )
+{
+  deleteFeature( fid );
+}
diff --git a/src/analysis/vector/geometry_checker/qgsvectorlayerfeaturepool.h b/src/analysis/vector/geometry_checker/qgsvectorlayerfeaturepool.h
@@ -27,15 +27,21 @@ email                : matthias@opengis.ch
  *
  * \since QGIS 3.4
  */
-class ANALYSIS_EXPORT QgsVectorLayerFeaturePool : public QgsFeaturePool
+class ANALYSIS_EXPORT QgsVectorLayerFeaturePool : public QObject, public QgsFeaturePool
 {
+    Q_OBJECT
+
   public:
     QgsVectorLayerFeaturePool( QgsVectorLayer *layer );
 
     bool addFeature( QgsFeature &feature, QgsFeatureSink::Flags flags = nullptr ) override;
     bool addFeatures( QgsFeatureList &features, QgsFeatureSink::Flags flags = nullptr ) override;
     void updateFeature( QgsFeature &feature ) override;
     void deleteFeature( QgsFeatureId fid ) override;
+
+  private slots:
+    void onGeometryChanged( QgsFeatureId fid, const QgsGeometry &geometry );
+    void onFeatureDeleted( QgsFeatureId fid );
 };
 
 #endif // QGSVECTORLAYERFEATUREPOOL_H

Original file line number	Diff line number	Diff line change
`@@ -140,6 +140,11 @@ void QgsFeaturePool::setFeatureIds( const QgsFeatureIds &ids )`
`140`	`140`	`mFeatureIds = ids;`
`141`	`141`	`}`
`142`	`142`
	`143`	`+bool QgsFeaturePool::isFeatureCached( QgsFeatureId fid )`
	`144`	`+{`
	`145`	`+ return mFeatureCache.contains( fid );`
	`146`	`+}`
	`147`	`+`
`143`	`148`	`QgsCoordinateReferenceSystem QgsFeaturePool::crs() const`
`144`	`149`	`{`
`145`	`150`	`return mCrs;`