Fix setEnabled

qgis · Aug 16, 2021 · 6de2f2d · 6de2f2d
1 parent 9772e95
commit 6de2f2d
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/python/gui/auto_generated/editorwidgets/qgsactionwidgetwrapper.sip.in b/python/gui/auto_generated/editorwidgets/qgsactionwidgetwrapper.sip.in
@@ -48,6 +48,8 @@ Sets the ``action``.
 
     virtual void setFeature( const QgsFeature &feature );
 
+    virtual void setEnabled( bool enabled );
+
 
 };
 

diff --git a/src/gui/editorwidgets/qgsactionwidgetwrapper.cpp b/src/gui/editorwidgets/qgsactionwidgetwrapper.cpp
@@ -33,6 +33,14 @@ void QgsActionWidgetWrapper::setFeature( const QgsFeature &feature )
   mFeature = feature;
 }
 
+void QgsActionWidgetWrapper::setEnabled( bool enabled )
+{
+  if ( valid() && layer() )
+  {
+    mActionButton->setEnabled( ! mAction.isEnabledOnlyWhenEditable() || enabled );
+  }
+}
+
 bool QgsActionWidgetWrapper::valid() const
 {
   return mAction.isValid() && mAction.runable();

diff --git a/src/gui/editorwidgets/qgsactionwidgetwrapper.h b/src/gui/editorwidgets/qgsactionwidgetwrapper.h
@@ -58,6 +58,7 @@ class GUI_EXPORT QgsActionWidgetWrapper : public QgsWidgetWrapper
   public slots:
 
     void setFeature( const QgsFeature &feature ) override;
+    void setEnabled( bool enabled ) override;
 
   private:
 

diff --git a/src/gui/qgsattributeform.cpp b/src/gui/qgsattributeform.cpp
@@ -1348,8 +1348,8 @@ void QgsAttributeForm::synchronizeState()
 
   for ( QgsWidgetWrapper *ww : std::as_const( mWidgets ) )
   {
-    QgsEditorWidgetWrapper *eww = qobject_cast<QgsEditorWidgetWrapper *>( ww );
-    if ( eww )
+
+    if ( QgsEditorWidgetWrapper *eww = qobject_cast<QgsEditorWidgetWrapper *>( ww ); eww )
     {
       QgsAttributeFormEditorWidget *formWidget = mFormEditorWidgets.value( eww->fieldIdx() );
 
@@ -1363,6 +1363,10 @@ void QgsAttributeForm::synchronizeState()
 
       updateIcon( eww );
     }
+    else  // handle QgsWidgetWrapper different than QgsEditorWidgetWrapper
+    {
+      ww->setEnabled( isEditable );
+    }
   }
 
   if ( mMode != QgsAttributeEditorContext::SearchMode )