Skip to content

Commit

Permalink
fix #2208
Browse files Browse the repository at this point in the history
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@12580 c8812cc2-4d05-0410-92ff-de0c093fc19c
  • Loading branch information
jef committed Dec 22, 2009
1 parent 873a9ed commit 6dcd0dd
Show file tree
Hide file tree
Showing 2 changed files with 65 additions and 18 deletions.
81 changes: 63 additions & 18 deletions src/providers/delimitedtext/qgsdelimitedtextprovider.cpp
Expand Up @@ -44,6 +44,66 @@ static const QString TEXT_PROVIDER_KEY = "delimitedtext";
static const QString TEXT_PROVIDER_DESCRIPTION = "Delimited text data provider";


QStringList QgsDelimitedTextProvider::splitLine( QString line )
{
QgsDebugMsg( "Attempting to split the input line: " + line + " using delimiter " + mDelimiter );

QStringList parts;
if ( mDelimiterType == "regexp" )
parts = line.split( mDelimiterRegexp );
else
parts = line.split( mDelimiter );

QgsDebugMsg( "Split line into " + QString::number( parts.size() ) + " parts" );

if ( mDelimiterType == "plain" )
{
QChar delim;
int i = 0, first = parts.size();
while ( i < parts.size() )
{
if ( delim == 0 && ( parts[i][0] == '"' || parts[i][0] == '\'' ) )
{
delim = parts[i][0];
first = i;
continue;
}

if ( delim != 0 && parts[i][ parts[i].length() - 1 ] == delim )
{
parts[first] = parts[first].mid( 1 );
parts[i] = parts[i].left( parts[i].length() - 1 );

if ( first < i )
{
QStringList values;
while ( first <= i )
{
values << parts[first];
parts.takeAt( first );
i--;
}

parts.insert( first, values.join( mDelimiter ) );
}

first = -1;
delim = 0;
}

i++;

if ( i == parts.size() && first >= 0 )
{
i = first + 1;
first = -1;
delim = 0;
}
}
}

return parts;
}

QgsDelimitedTextProvider::QgsDelimitedTextProvider( QString uri )
: QgsVectorDataProvider( uri ),
Expand Down Expand Up @@ -137,14 +197,7 @@ QgsDelimitedTextProvider::QgsDelimitedTextProvider( QString uri )
{
// Get the fields from the header row and store them in the
// fields vector
QgsDebugMsg( "Attempting to split the input line: " + line + " using delimiter " + mDelimiter );

QStringList fieldList;
if ( mDelimiterType == "regexp" )
fieldList = line.split( mDelimiterRegexp );
else
fieldList = line.split( mDelimiter );
QgsDebugMsg( "Split line into " + QString::number( fieldList.size() ) + " parts" );
QStringList fieldList = splitLine( line );

// We don't know anything about a text based field other
// than its name. All fields are assumed to be text
Expand Down Expand Up @@ -185,11 +238,7 @@ QgsDelimitedTextProvider::QgsDelimitedTextProvider( QString uri )
mNumberFeatures++;

// split the line on the delimiter
QStringList parts;
if ( mDelimiterType == "regexp" )
parts = line.split( mDelimiterRegexp );
else
parts = line.split( mDelimiter );
QStringList parts = splitLine( line );

// Skip malformed lines silently. Report line number with nextFeature()
if ( attributeFields.size() != parts.size() )
Expand Down Expand Up @@ -293,11 +342,7 @@ bool QgsDelimitedTextProvider::nextFeature( QgsFeature& feature )
QString line = mStream->readLine(); // Default local 8 bit encoding

// lex the tokens from the current data line
QStringList tokens;
if ( mDelimiterType == "regexp" )
tokens = line.split( mDelimiterRegexp );
else
tokens = line.split( mDelimiter );
QStringList tokens = splitLine( line );

bool xOk = false;
bool yOk = false;
Expand Down
2 changes: 2 additions & 0 deletions src/providers/delimitedtext/qgsdelimitedtextprovider.h
Expand Up @@ -219,4 +219,6 @@ class QgsDelimitedTextProvider : public QgsVectorDataProvider
};
wkbPoint mWKBpt;

QStringList splitLine( QString line );

};

0 comments on commit 6dcd0dd

Please sign in to comment.