use stringToSafeFilename()

alexbruy · nyalldawson · commit 6daf48e231a6 · 2023-09-23T07:27:11.000+10:00
diff --git a/src/analysis/processing/qgsalgorithmsplitvectorlayer.cpp b/src/analysis/processing/qgsalgorithmsplitvectorlayer.cpp
@@ -18,6 +18,7 @@
 #include "qgsalgorithmsplitvectorlayer.h"
 #include "qgsvectorfilewriter.h"
 #include "qgsvariantutils.h"
+#include "qgsfileutils.h"
 
 ///@cond PRIVATE
 
@@ -139,9 +140,7 @@ QVariantMap QgsSplitVectorLayerAlgorithm::processAlgorithm( const QVariantMap &p
     }
     else
     {
-      QString value = ( *it ).toString();
-      value.replace( QRegularExpression( "<|>|\\:|\\\\|\\/|\\||\\?|\\*|\"" ), QStringLiteral( "_" ) );
-      fileName = QStringLiteral( "%1%2.%3" ).arg( baseName ).arg( value ).arg( outputFormat );
+      fileName = QStringLiteral( "%1%2.%3" ).arg( baseName ).arg( QgsFileUtils::stringToSafeFilename( ( *it ).toString() ) ).arg( outputFormat );
     }
     feedback->pushInfo( QObject::tr( "Creating layer: %1" ).arg( fileName ) );
 

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`#include "qgsalgorithmsplitvectorlayer.h"`
`19`	`19`	`#include "qgsvectorfilewriter.h"`
`20`	`20`	`#include "qgsvariantutils.h"`
	`21`	`+#include "qgsfileutils.h"`
`21`	`22`
`22`	`23`	`///@cond PRIVATE`
`23`	`24`
`@@ -139,9 +140,7 @@ QVariantMap QgsSplitVectorLayerAlgorithm::processAlgorithm( const QVariantMap &p`
`139`	`140`	`}`
`140`	`141`	`else`
`141`	`142`	`{`
`142`		`- QString value = ( *it ).toString();`
`143`		`- value.replace( QRegularExpression( "<\|>\|\\:\|\\\\\|\\/\|\\\|\|\\?\|\\*\|\"" ), QStringLiteral( "_" ) );`
`144`		`- fileName = QStringLiteral( "%1%2.%3" ).arg( baseName ).arg( value ).arg( outputFormat );`
	`143`	`+ fileName = QStringLiteral( "%1%2.%3" ).arg( baseName ).arg( QgsFileUtils::stringToSafeFilename( ( *it ).toString() ) ).arg( outputFormat );`
`145`	`144`	`}`
`146`	`145`	`feedback->pushInfo( QObject::tr( "Creating layer: %1" ).arg( fileName ) );`
`147`	`146`