Fix leak when adding symbols

qgis · Jul 29, 2020 · 6d00694 · 6d00694
1 parent f48a79c
commit 6d00694
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/gui/symbology/qgsstylemanagerdialog.cpp b/src/gui/symbology/qgsstylemanagerdialog.cpp
@@ -673,9 +673,10 @@ void QgsStyleManagerDialog::pasteItem()
     }
 
     QStringList symbolTags = saveDlg.tags().split( ',' );
-    mStyle->addSymbol( saveDlg.name(), tempSymbol->clone() );
+    QgsSymbol *newSymbol = tempSymbol.get();
+    mStyle->addSymbol( saveDlg.name(), tempSymbol.release() );
     // make sure the symbol is stored
-    mStyle->saveSymbol( saveDlg.name(), tempSymbol->clone(), saveDlg.isFavorite(), symbolTags );
+    mStyle->saveSymbol( saveDlg.name(), newSymbol, saveDlg.isFavorite(), symbolTags );
     return;
   }
 

diff --git a/src/gui/symbology/qgssymbolslistwidget.cpp b/src/gui/symbology/qgssymbolslistwidget.cpp
@@ -218,10 +218,11 @@ void QgsSymbolsListWidget::saveSymbol()
   QStringList symbolTags = saveDlg.tags().split( ',' );
 
   // add new symbol to style and re-populate the list
-  mStyle->addSymbol( saveDlg.name(), mSymbol->clone() );
+  QgsSymbol *newSymbol = mSymbol->clone();
+  mStyle->addSymbol( saveDlg.name(), newSymbol );
 
   // make sure the symbol is stored
-  mStyle->saveSymbol( saveDlg.name(), mSymbol->clone(), saveDlg.isFavorite(), symbolTags );
+  mStyle->saveSymbol( saveDlg.name(), newSymbol, saveDlg.isFavorite(), symbolTags );
 }
 
 void QgsSymbolsListWidget::clipFeaturesToggled( bool checked )