Fix virtual layers fail if table field names have special characters

nyalldawson · nyalldawson · commit 6c392124ca46 · 2018-01-18T16:23:49.000+10:00
Fixes #16943
diff --git a/src/providers/virtual/qgsvirtuallayersqlitemodule.cpp b/src/providers/virtual/qgsvirtuallayersqlitemodule.cpp
@@ -218,7 +218,7 @@ struct VTable
             typeName = QStringLiteral( "text" );
             break;
         }
-        sqlFields << field.name() + " " + typeName;
+        sqlFields << QStringLiteral( "\"%1\" %2" ).arg( field.name(), typeName );
       }
 
       QgsVectorDataProvider *provider = mLayer ? mLayer->dataProvider() : mProvider;
diff --git a/tests/src/python/test_provider_virtual.py b/tests/src/python/test_provider_virtual.py
@@ -16,6 +16,7 @@
 import os
 
 from qgis.core import (QgsVectorLayer,
+                       QgsField,
                        QgsFeature,
                        QgsFeatureRequest,
                        QgsGeometry,
@@ -847,6 +848,29 @@ def test_joined_layers_conversion(self):
 
         QgsProject.instance().removeMapLayers([v1.id(), v2.id(), v3.id()])
 
+    def testFieldsWithSpecialCharacters(self):
+        ml = QgsVectorLayer("Point?srid=EPSG:4326&field=123:int", "mem_with_nontext_fieldnames", "memory")
+        self.assertEqual(ml.isValid(), True)
+        QgsProject.instance().addMapLayer(ml)
+
+        ml.startEditing()
+        self.assertTrue(ml.addAttribute(QgsField('abc:123', QVariant.String)))
+        f1 = QgsFeature(ml.fields())
+        f1.setGeometry(QgsGeometry.fromWkt('POINT(0 0)'))
+        f2 = QgsFeature(ml.fields())
+        f2.setGeometry(QgsGeometry.fromWkt('POINT(1 1)'))
+        ml.addFeatures([f1, f2])
+        ml.commitChanges()
+
+        vl = QgsVectorLayer("?query=select * from mem_with_nontext_fieldnames", "vl", "virtual")
+        self.assertEqual(vl.isValid(), True)
+        self.assertEqual(vl.fields().at(0).name(), '123')
+        self.assertEqual(vl.fields().at(1).name(), 'abc:123')
+
+        self.assertEqual(vl.featureCount(), 2)
+
+        QgsProject.instance().removeMapLayer(ml)
+
 
 if __name__ == '__main__':
     unittest.main()

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ struct VTable`
`218`	`218`	`typeName = QStringLiteral( "text" );`
`219`	`219`	`break;`
`220`	`220`	`}`
`221`		`- sqlFields << field.name() + " " + typeName;`
	`221`	`+ sqlFields << QStringLiteral( "\"%1\" %2" ).arg( field.name(), typeName );`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`QgsVectorDataProvider *provider = mLayer ? mLayer->dataProvider() : mProvider;`