[WFS client] Revert read buffer size limitation (fixes #29258, fixes #27626)

rouault · nyalldawson · commit 6abc15d11338 · 2019-05-31T06:30:35.000+10:00
This apparently caused deadlock issues. Credit to @nyalldawson for spotting the offending commit. Partial revert of 0addae5
diff --git a/src/providers/wfs/qgswfsrequest.cpp b/src/providers/wfs/qgswfsrequest.cpp
@@ -27,8 +27,6 @@
 #include <QFuture>
 #include <QtConcurrent>
 
-const qint64 READ_BUFFER_SIZE_HINT = 1024 * 1024;
-
 QgsWfsRequest::QgsWfsRequest( const QgsWFSDataSourceURI &uri )
   : mUri( uri )
   , mErrorCode( QgsWfsRequest::NoError )
@@ -143,7 +141,6 @@ bool QgsWfsRequest::sendGET( const QUrl &url, bool synchronous, bool forceRefres
     success = true;
     mReply = QgsNetworkAccessManager::instance()->get( request );
 
-    mReply->setReadBufferSize( READ_BUFFER_SIZE_HINT );
     if ( !mUri.auth().setAuthorizationReply( mReply ) )
     {
       mErrorCode = QgsWfsRequest::NetworkError;
@@ -264,7 +261,6 @@ bool QgsWfsRequest::sendPOST( const QUrl &url, const QString &contentTypeHeader,
   request.setHeader( QNetworkRequest::ContentTypeHeader, contentTypeHeader );
 
   mReply = QgsNetworkAccessManager::instance()->post( request, data );
-  mReply->setReadBufferSize( READ_BUFFER_SIZE_HINT );
   if ( !mUri.auth().setAuthorizationReply( mReply ) )
   {
     mErrorCode = QgsWfsRequest::NetworkError;
@@ -356,7 +352,6 @@ void QgsWfsRequest::replyFinished()
 
           QgsDebugMsgLevel( QStringLiteral( "redirected: %1 forceRefresh=%2" ).arg( redirect.toString() ).arg( mForceRefresh ), 4 );
           mReply = QgsNetworkAccessManager::instance()->get( request );
-          mReply->setReadBufferSize( READ_BUFFER_SIZE_HINT );
           if ( !mUri.auth().setAuthorizationReply( mReply ) )
           {
             mResponse.clear();
