Skip to content

Commit

Permalink
QString fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Apr 2, 2023
1 parent 8c63f89 commit 6a7e929
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/3d/qgsrubberband3d.cpp
Expand Up @@ -129,7 +129,7 @@ void QgsRubberBand3D::setColor( QColor color )
{
mLineMaterial->setLineColor( color );
mMarkerSymbol->setColor( color.lighter( 130 ) );
if ( mMarkerSymbol->symbolLayerCount() > 0 && mMarkerSymbol->symbolLayer( 0 )->layerType() == QStringLiteral( "SimpleMarker" ) )
if ( mMarkerSymbol->symbolLayerCount() > 0 && mMarkerSymbol->symbolLayer( 0 )->layerType() == QLatin1String( "SimpleMarker" ) )
{
static_cast<QgsMarkerSymbolLayer *>( mMarkerSymbol->symbolLayer( 0 ) )->setStrokeColor( color );
}
Expand Down
2 changes: 1 addition & 1 deletion src/gui/codeeditors/qgscodeeditorpython.cpp
Expand Up @@ -508,7 +508,7 @@ QString QgsCodeEditorPython::reformatCodeString( const QString &string )
}
else
{
const QString modules = missingModules.join( QStringLiteral( ", " ) );
const QString modules = missingModules.join( QLatin1String( ", " ) );
showMessage( tr( "Reformat Code" ), tr( "The Python modules %1 are missing" ).arg( modules ), Qgis::MessageLevel::Warning );
}
}
Expand Down
8 changes: 4 additions & 4 deletions tests/src/analysis/testqgsprocessingpdalalgs.cpp
Expand Up @@ -154,7 +154,7 @@ void TestQgsProcessingPdalAlgs::reproject()
QCOMPARE( args, QStringList() << QStringLiteral( "translate" )
<< QStringLiteral( "--input=%1" ).arg( mPointCloudLayerPath )
<< QStringLiteral( "--output=%1" ).arg( outputPointCloud )
<< QStringLiteral( "--transform-crs=%1" ).arg( QStringLiteral( "EPSG:4326" ) )
<< QStringLiteral( "--transform-crs=%1" ).arg( QLatin1String( "EPSG:4326") )

This comment has been minimized.

Copy link
@nirvn

nirvn Apr 3, 2023

Contributor

@nyalldawson , is the missing space after in between the double quote and the closing parenthesis going to trigger an error?

);

// set max threads to 2, a --threads argument should be added
Expand All @@ -163,7 +163,7 @@ void TestQgsProcessingPdalAlgs::reproject()
QCOMPARE( args, QStringList() << QStringLiteral( "translate" )
<< QStringLiteral( "--input=%1" ).arg( mPointCloudLayerPath )
<< QStringLiteral( "--output=%1" ).arg( outputPointCloud )
<< QStringLiteral( "--transform-crs=%1" ).arg( QStringLiteral( "EPSG:4326" ) )
<< QStringLiteral( "--transform-crs=%1" ).arg( QLatin1String( "EPSG:4326") )
<< QStringLiteral( "--threads=2" )
);
}
Expand All @@ -188,7 +188,7 @@ void TestQgsProcessingPdalAlgs::fixProjection()
QCOMPARE( args, QStringList() << QStringLiteral( "translate" )
<< QStringLiteral( "--input=%1" ).arg( mPointCloudLayerPath )
<< QStringLiteral( "--output=%1" ).arg( outputPointCloud )
<< QStringLiteral( "--assign-crs=%1" ).arg( QStringLiteral( "EPSG:4326" ) )
<< QStringLiteral( "--assign-crs=%1" ).arg( QLatin1String( "EPSG:4326") )
);

// set max threads to 2, a --threads argument should be added
Expand All @@ -197,7 +197,7 @@ void TestQgsProcessingPdalAlgs::fixProjection()
QCOMPARE( args, QStringList() << QStringLiteral( "translate" )
<< QStringLiteral( "--input=%1" ).arg( mPointCloudLayerPath )
<< QStringLiteral( "--output=%1" ).arg( outputPointCloud )
<< QStringLiteral( "--assign-crs=%1" ).arg( QStringLiteral( "EPSG:4326" ) )
<< QStringLiteral( "--assign-crs=%1" ).arg( QLatin1String( "EPSG:4326") )
<< QStringLiteral( "--threads=2" )
);
}
Expand Down

0 comments on commit 6a7e929

Please sign in to comment.