Q_FOREACH use to iterate over fields

pblottiere · pblottiere · commit 6a1c141f10fe · 2017-06-30T08:22:27.000+01:00
diff --git a/src/gui/qgsattributeform.cpp b/src/gui/qgsattributeform.cpp
@@ -1973,9 +1973,8 @@ void QgsAttributeForm::updateJoinedFields( const QgsEditorWidgetWrapper &eww )
     }
     else
     {
-      for ( int i = 0; i < joinFeature.fields().count(); i++ )
+      Q_FOREACH ( const QgsField &field, joinFeature.fields() )
       {
-        QgsField field = joinFeature.fields().field( i );
         QString prefixedName = info->prefixedFieldName( field );
         changeAttribute( prefixedName, joinFeature.attribute( field.name() ) );
       }

Original file line number	Diff line number	Diff line change
`@@ -1973,9 +1973,8 @@ void QgsAttributeForm::updateJoinedFields( const QgsEditorWidgetWrapper &eww )`
`1973`	`1973`	`}`
`1974`	`1974`	`else`
`1975`	`1975`	`{`
`1976`		`- for ( int i = 0; i < joinFeature.fields().count(); i++ )`
	`1976`	`+ Q_FOREACH ( const QgsField &field, joinFeature.fields() )`
`1977`	`1977`	`{`
`1978`		`- QgsField field = joinFeature.fields().field( i );`
`1979`	`1978`	`QString prefixedName = info->prefixedFieldName( field );`
`1980`	`1979`	`changeAttribute( prefixedName, joinFeature.attribute( field.name() ) );`
`1981`	`1980`	`}`