Skip to content

Commit 678758c

Browse files
alexbruyalexbruy
committedDec 11, 2017
use 443 (HTTPS) port when testing help URLs
·
ltr-3_40final-3_0_0
1 parent 1c6ba55 commit 678758c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/gui/qgshelp.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ bool QgsHelp::urlExists( const QString &url )
152152
socket.setProxy( proxy );
153153
}
154154

155-
socket.connectToHost( helpUrl.host(), 80 );
155+
socket.connectToHost( helpUrl.host(), 443 );
156156
if ( socket.waitForConnected() )
157157
{
158158
socket.write( "HEAD " + helpUrl.path().toUtf8() + " HTTP/1.1\r\n"

1 commit comments

Comments
 (1)

rduivenvoorde commented on Dec 12, 2017

@rduivenvoorde
rduivenvoorde
on Dec 12, 2017
Contributor

@alexbruy I know this was one of my own suggestions, but... this does not work.
you will never open the right page.

Apparently connecting to a 443 socket without any ssl stuff just returns a bad request:

"<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>400 Bad Request</title>
</hea..."

So maybe it is better to keep the http url and port 80, then redirection should do the work
We could use the httpS url and port 80 too, but that is a little unclear.

OR forget this whole test, and do the 'nothing found' magic somewhere in the website.

I was thinking about pointing to the search page of the (english?) version:
https://docs.qgis.org/testing/en/search.html

Please sign in to comment.