[MSSQL] Don't MakeValid on geometries

MakeValid can make geometry data we can't read back (e.g GEOMETRYCOLLECTION) which is worse then just a user error in the first place. QGIS has the tools to deal with this so let it came back to the user to fix
qgis · Jun 23, 2017 · 62f4534 · 62f4534 · nyalldawson · Jun 23, 2017
1 parent 81855a7
commit 62f4534
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/providers/mssql/qgsmssqlprovider.cpp b/src/providers/mssql/qgsmssqlprovider.cpp
@@ -883,10 +883,10 @@ bool QgsMssqlProvider::addFeatures( QgsFeatureList &flist, Flags flags )
       if ( mGeometryColType == QLatin1String( "geometry" ) )
       {
         if ( mUseWkb )
-          values += QStringLiteral( "geometry::STGeomFromWKB(%1,%2).MakeValid()" ).arg(
+          values += QStringLiteral( "geometry::STGeomFromWKB(%1,%2)" ).arg(
                       QStringLiteral( "?" ), QString::number( mSRId ) );
         else
-          values += QStringLiteral( "geometry::STGeomFromText(%1,%2).MakeValid()" ).arg(
+          values += QStringLiteral( "geometry::STGeomFromText(%1,%2)" ).arg(
                       QStringLiteral( "?" ), QString::number( mSRId ) );
       }
       else