Significantly improve OGR fetching speed - set ignored field only on …

…select() Beware: featureAtId() may interfere, this should be checked.
qgis · Nov 7, 2011 · 625ff11 · 625ff11
1 parent 1d7d1c6
commit 625ff11
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/providers/ogr/qgsogrprovider.cpp b/src/providers/ogr/qgsogrprovider.cpp
@@ -626,9 +626,6 @@ bool QgsOgrProvider::nextFeature( QgsFeature& feature )
   OGRFeatureH fet;
   QgsRectangle selectionRect;
 
-  setRelevantFields( mFetchGeom || mUseIntersect || !mFetchRect.isEmpty(),
-                     mAttributesToFetch );
-
   while (( fet = OGR_L_GetNextFeature( ogrLayer ) ) )
   {
     // skip features without geometry
@@ -727,6 +724,9 @@ void QgsOgrProvider::select( QgsAttributeList fetchAttributes, QgsRectangle rect
   mFetchGeom = fetchGeometry;
   mFetchRect = rect;
 
+  setRelevantFields( mFetchGeom || mUseIntersect || !mFetchRect.isEmpty(),
+                     mAttributesToFetch );
+
   // spatial query to select features
   if ( rect.isEmpty() )
   {