Show CRS details in tooltips for destination X/Y values

Helps clarify for users exactly what CRS these destination coordinates are in
qgis · Feb 14, 2022 · 622c120 · 622c120
1 parent 93564e0
commit 622c120
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/app/georeferencer/qgsgcplistmodel.cpp b/src/app/georeferencer/qgsgcplistmodel.cpp
@@ -117,6 +117,12 @@ QVariant QgsGCPListModel::data( const QModelIndex &index, int role ) const
           switch ( role )
           {
             case Qt::ToolTipRole:
+            {
+              const QString crsString = mTargetCrs.userFriendlyIdentifier();
+              const double value = column == QgsGCPListModel::Column::DestinationX ? transformedDestinationPoint.x() : transformedDestinationPoint.y();
+              return QStringLiteral( "<b>%1</b><br>%2" ).arg( value ).arg( crsString );
+            }
+
             case Qt::EditRole:
             case Qt::UserRole:
               // use full precision
@@ -329,6 +335,7 @@ QVariant QgsGCPListModel::headerData( int section, Qt::Orientation orientation,
       switch ( role )
       {
         case Qt::DisplayRole:
+        case Qt::ToolTipRole:
         {
           QString residualUnitType;
           switch ( residualUnit() )
@@ -360,9 +367,25 @@ QVariant QgsGCPListModel::headerData( int section, Qt::Orientation orientation,
             case QgsGCPListModel::Column::SourceY:
               return tr( "Source Y" );
             case QgsGCPListModel::Column::DestinationX:
-              return tr( "Dest. X" );
             case QgsGCPListModel::Column::DestinationY:
-              return tr( "Dest. Y" );
+            {
+              const QString heading = static_cast< Column >( section ) == QgsGCPListModel::Column::DestinationX ? tr( "Dest. X" ) : tr( "Dest. Y" );
+              switch ( role )
+              {
+                case Qt::DisplayRole:
+                  return heading;
+
+                case Qt::ToolTipRole:
+                {
+                  const QString crsString = mTargetCrs.userFriendlyIdentifier();
+                  return QStringLiteral( "<b>%1</b><br>%2" ).arg( heading, crsString );
+                }
+
+                default:
+                  break;
+              }
+              break;
+            }
             case QgsGCPListModel::Column::ResidualDx:
               return tr( "dX (%1)" ).arg( residualUnitType );
             case QgsGCPListModel::Column::ResidualDy:

diff --git a/tests/src/app/testqgsgeoreferencer.cpp b/tests/src/app/testqgsgeoreferencer.cpp
@@ -642,6 +642,9 @@ void TestQgsGeoreferencer::testListModel()
   QCOMPARE( model.data( model.index( 0, 3 ) ).toString(), QStringLiteral( "3350923.1250" ) );
   QCOMPARE( model.data( model.index( 0, 4 ) ).toString(), QStringLiteral( "-30.0000" ) );
   QCOMPARE( model.data( model.index( 0, 5 ) ).toString(), QStringLiteral( "40.0000" ) );
+  QCOMPARE( model.data( model.index( 0, 4 ), Qt::ToolTipRole ).toString(), QStringLiteral( "<b>-30</b><br>EPSG:4326 - WGS 84" ) );
+  QCOMPARE( model.data( model.index( 0, 5 ), Qt::ToolTipRole ).toString(), QStringLiteral( "<b>40</b><br>EPSG:4326 - WGS 84" ) );
+
   QCOMPARE( model.data( model.index( 0, 6 ) ).toString(), QStringLiteral( "n/a" ) );
   QCOMPARE( model.data( model.index( 0, 7 ) ).toString(), QStringLiteral( "n/a" ) );
   QCOMPARE( model.data( model.index( 0, 8 ) ).toString(), QStringLiteral( "n/a" ) );
@@ -651,6 +654,9 @@ void TestQgsGeoreferencer::testListModel()
   QCOMPARE( model.data( model.index( 1, 3 ) ).toString(), QStringLiteral( "3350923.1250" ) );
   QCOMPARE( model.data( model.index( 1, 4 ) ).toString(), QStringLiteral( "150.0000" ) );
   QCOMPARE( model.data( model.index( 1, 5 ) ).toString(), QStringLiteral( "-30.0000" ) );
+  // tooltip should show target CRS details for user clarification
+  QCOMPARE( model.data( model.index( 1, 4 ), Qt::ToolTipRole ).toString(), QStringLiteral( "<b>150</b><br>EPSG:4326 - WGS 84" ) );
+  QCOMPARE( model.data( model.index( 1, 5 ), Qt::ToolTipRole ).toString(), QStringLiteral( "<b>-30</b><br>EPSG:4326 - WGS 84" ) );
   QCOMPARE( model.data( model.index( 1, 6 ) ).toString(), QStringLiteral( "n/a" ) );
   QCOMPARE( model.data( model.index( 1, 7 ) ).toString(), QStringLiteral( "n/a" ) );
   QCOMPARE( model.data( model.index( 1, 8 ) ).toString(), QStringLiteral( "n/a" ) );