[processing] fixed check for empty param for strings

volaya · volaya · commit 61a10df45283 · 2016-10-17T08:32:57.000+02:00
diff --git a/python/plugins/processing/core/parameters.py b/python/plugins/processing/core/parameters.py
@@ -747,7 +747,7 @@ def __init__(self, name='', description='', default=None, multiline=False,
         self.evaluateExpressions = parseBool(evaluateExpressions)
 
     def setValue(self, obj):
-        if obj is None:
+        if not bool(obj):
             if not self.optional:
                 return False
             self.value = None

-Original file line number
+Diff line change
         self.evaluateExpressions = parseBool(evaluateExpressions)
     def setValue(self, obj):
 -        if obj is None:
 +        if not bool(obj):Collapse commentComment on line R750
gacarrillor commented on Oct 18, 2016 
gacarrillor
on Oct 18, 2016
Member
@volaya, I think this has affected OGR algs. Try for instance "Convert format". If you don't enter optional parameters, you'll get None into the OGR command, making it impossible to run. Could you please confirm and if so, fix it (revert)?
strk replied on Oct 18, 2016 
strk
on Oct 18, 2016
Contributor
Confirmed, see mailing list thread:

https://lists.osgeo.org/pipermail/qgis-developer/2016-October/045336.html
Code has comments. Press enter to view.
             if not self.optional:
                 return False
             self.value = None