Set feature valid on setId

m-kuhn · m-kuhn · commit 616b4dd9879b · 2017-03-18T12:11:52.000+01:00
diff --git a/src/core/qgsfeature.cpp b/src/core/qgsfeature.cpp
@@ -128,6 +128,7 @@ void QgsFeature::setId( QgsFeatureId id )
 
   d.detach();
   d->fid = id;
+  d->valid = true;
 }
 
 QgsAttributes QgsFeature::attributes() const
diff --git a/tests/src/python/test_qgsfeature.py b/tests/src/python/test_qgsfeature.py
@@ -63,9 +63,8 @@ def test_Validity(self):
         self.assertTrue(f.isValid())
         f.setValid(False)
         self.assertFalse(f.isValid())
-
-        f.setValid(False)
-        self.assertFalse(f.isValid())
+        f.setId(27)
+        self.assertTrue(f.isValid())
 
     def test_Attributes(self):
         myPath = os.path.join(unitTestDataPath(), 'lines.shp')

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ void QgsFeature::setId( QgsFeatureId id )`
`128`	`128`
`129`	`129`	`d.detach();`
`130`	`130`	`d->fid = id;`
	`131`	`+ d->valid = true;`
`131`	`132`	`}`
`132`	`133`
`133`	`134`	`QgsAttributes QgsFeature::attributes() const`