Fix slightly oversized filter clear icons

nyalldawson · nyalldawson · commit 60a56c372a07 · 2017-11-27T10:16:47.000+10:00
And make sure on low-dpi screens the icon size is 16px for
pixel-snapped rendering of the svg
diff --git a/src/gui/qgsfilterlineedit.cpp b/src/gui/qgsfilterlineedit.cpp
@@ -32,7 +32,10 @@ QgsFilterLineEdit::QgsFilterLineEdit( QWidget *parent, const QString &nullValue
   setMouseTracking( true );
 
   QIcon clearIcon = QgsApplication::getThemeIcon( "/mIconClearText.svg" );
-  int iconSize = Qgis::UI_SCALE_FACTOR * fontMetrics().height();
+
+  // icon size is about 2/3 height of text, but minimum size of 16
+  int iconSize = std::floor( std::max( Qgis::UI_SCALE_FACTOR * fontMetrics().height() * 0.75, 16.0 ) );
+
   mClearIconSize = QSize( iconSize, iconSize );
   mClearIconPixmap = clearIcon.pixmap( mClearIconSize );
   QIcon hoverIcon = QgsApplication::getThemeIcon( "/mIconClearTextHover.svg" );
