Fix crash after running GDAL alg from processing (fixes #18004)

wonder-sk · wonder-sk · commit 6096e5c25d2e · 2018-02-12T10:24:13.000+01:00
This was happening only with GDAL trunk

Processing first tries to load output as a vector, then as a raster
and output from raster algs would crash in OGR provider constructor
due to null pointer
diff --git a/src/providers/ogr/qgsogrprovider.cpp b/src/providers/ogr/qgsogrprovider.cpp
@@ -469,9 +469,12 @@ QgsOgrProvider::QgsOgrProvider( QString const &uri )
   bool supportsBoolean = false;
 
 #if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(2,3,0)
-  const char *pszDataTypes = GDALGetMetadataItem( mOgrOrigLayer->driver(), GDAL_DMD_CREATIONFIELDDATASUBTYPES, nullptr );
-  if ( pszDataTypes && strstr( pszDataTypes, "Boolean" ) )
-    supportsBoolean = true;
+  if ( mOgrOrigLayer )
+  {
+    const char *pszDataTypes = GDALGetMetadataItem( mOgrOrigLayer->driver(), GDAL_DMD_CREATIONFIELDDATASUBTYPES, nullptr );
+    if ( pszDataTypes && strstr( pszDataTypes, "Boolean" ) )
+      supportsBoolean = true;
+  }
 #else
   if ( mGDALDriverName == QLatin1String( "GeoJSON" ) ||
        mGDALDriverName == QLatin1String( "GML" ) ||
