disable feature picker when no feature is available in expression pre…

…view widget (#37518)
qgis · Jul 7, 2020 · 5f6dab0 · 5f6dab0
1 parent 960e533
commit 5f6dab0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/gui/qgsexpressionpreviewwidget.cpp b/src/gui/qgsexpressionpreviewwidget.cpp
@@ -55,10 +55,13 @@ void QgsExpressionPreviewWidget::setCurrentFeature( const QgsFeature &feature )
     QgsFeature validFeature( feature );
     validFeature.setValid( true );
     mExpressionContext.setFeature( validFeature );
+    mFeaturePickerWidget->setEnabled( false );
+    mFeaturePickerWidget->setToolTip( tr( "No feature was found on this layer to evaluate the expression." ) );
   }
   else
   {
     mExpressionContext.setFeature( feature );
+    mFeaturePickerWidget->setEnabled( true );
   }
   refreshPreview();
 }

diff --git a/src/gui/qgsfeaturepickerwidget.cpp b/src/gui/qgsfeaturepickerwidget.cpp
@@ -81,7 +81,6 @@ QgsFeaturePickerWidget::QgsFeaturePickerWidget( QWidget *parent )
   mComboBox->setModel( mModel );
 
   connect( mLineEdit, &QgsFilterLineEdit::textEdited, this, &QgsFeaturePickerWidget::onCurrentTextChanged );
-
 }
 
 QgsVectorLayer *QgsFeaturePickerWidget::layer() const