Skip to content

Commit 5e6501f

Browse files
committedOct 23, 2017
[Geometry checker] Add layer column to result table
1 parent b80fa36 commit 5e6501f

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed
 

‎src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,14 @@ void QgsGeometryCheckerResultTab::addError( QgsGeometryCheckError *error )
141141
ui.tableWidgetErrors->insertRow( row );
142142
QTableWidgetItem *idItem = new QTableWidgetItem();
143143
idItem->setData( Qt::EditRole, error->featureId() != FEATUREID_NULL ? QVariant( error->featureId() ) : QVariant() );
144-
ui.tableWidgetErrors->setItem( row, 0, idItem );
145-
ui.tableWidgetErrors->setItem( row, 1, new QTableWidgetItem( error->description() ) );
146-
ui.tableWidgetErrors->setItem( row, 2, new QTableWidgetItem( posStr ) );
144+
ui.tableWidgetErrors->setItem( row, 0, new QTableWidgetItem( mChecker->getContext()->featurePools[error->layerId()]->getLayer()->name() ) );
145+
ui.tableWidgetErrors->setItem( row, 1, idItem );
146+
ui.tableWidgetErrors->setItem( row, 2, new QTableWidgetItem( error->description() ) );
147+
ui.tableWidgetErrors->setItem( row, 3, new QTableWidgetItem( posStr ) );
147148
QTableWidgetItem *valueItem = new QTableWidgetItem();
148149
valueItem->setData( Qt::EditRole, error->value() );
149-
ui.tableWidgetErrors->setItem( row, 3, valueItem );
150-
ui.tableWidgetErrors->setItem( row, 4, new QTableWidgetItem( QLatin1String( "" ) ) );
150+
ui.tableWidgetErrors->setItem( row, 4, valueItem );
151+
ui.tableWidgetErrors->setItem( row, 5, new QTableWidgetItem( QLatin1String( "" ) ) );
151152
ui.tableWidgetErrors->item( row, 0 )->setData( Qt::UserRole, QVariant::fromValue( error ) );
152153
++mErrorCount;
153154
ui.labelErrorCount->setText( tr( "Total errors: %1, fixed errors: %2" ).arg( mErrorCount ).arg( mFixedCount ) );
@@ -164,17 +165,16 @@ void QgsGeometryCheckerResultTab::updateError( QgsGeometryCheckError *error, boo
164165
{
165166
return;
166167
}
167-
// Disable sorting to prevent crashes: if i.e. sorting by col 0, as soon as the item(row, 0)
168-
// is set, the row is potentially moved due to sorting, and subsequent item(row, col) reference wrong
169-
// item
168+
// Disable sorting to prevent crashes: if i.e. sorting by col 0, as soon as the item(row, 0) is set,
169+
// the row is potentially moved due to sorting, and subsequent item(row, col) reference wrong item
170170
ui.tableWidgetErrors->setSortingEnabled( false );
171171

172172
int row = mErrorMap.value( error ).row();
173173
int prec = 7 - std::floor( std::max( 0., std::log10( std::max( error->location().x(), error->location().y() ) ) ) );
174174
QString posStr = QStringLiteral( "%1, %2" ).arg( error->location().x(), 0, 'f', prec ).arg( error->location().y(), 0, 'f', prec );
175175

176-
ui.tableWidgetErrors->item( row, 2 )->setText( posStr );
177-
ui.tableWidgetErrors->item( row, 3 )->setData( Qt::EditRole, error->value() );
176+
ui.tableWidgetErrors->item( row, 3 )->setText( posStr );
177+
ui.tableWidgetErrors->item( row, 4 )->setData( Qt::EditRole, error->value() );
178178
if ( error->status() == QgsGeometryCheckError::StatusFixed )
179179
{
180180
setRowStatus( row, Qt::green, tr( "Fixed: %1" ).arg( error->resolutionMessage() ), true );
@@ -533,7 +533,7 @@ void QgsGeometryCheckerResultTab::setRowStatus( int row, const QColor &color, co
533533
item->setForeground( Qt::lightGray );
534534
}
535535
}
536-
ui.tableWidgetErrors->item( row, 4 )->setText( message );
536+
ui.tableWidgetErrors->item( row, 5 )->setText( message );
537537
}
538538

539539
void QgsGeometryCheckerResultTab::setDefaultResolutionMethods()

‎src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.ui

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,11 @@
293293
<attribute name="verticalHeaderVisible">
294294
<bool>false</bool>
295295
</attribute>
296+
<column>
297+
<property name="text">
298+
<string>Layer</string>
299+
</property>
300+
</column>
296301
<column>
297302
<property name="text">
298303
<string>Object ID</string>

0 commit comments

Comments
 (0)
Please sign in to comment.