Fix double registration of model outputs

qgis · Feb 1, 2018 · 5e07451 · 5e07451
1 parent 216821c
commit 5e07451
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/src/core/processing/models/qgsprocessingmodelalgorithm.cpp b/src/core/processing/models/qgsprocessingmodelalgorithm.cpp
@@ -774,15 +774,6 @@ void QgsProcessingModelAlgorithm::updateDestinationParameters()
       std::unique_ptr< QgsProcessingParameterDefinition > param( source->clone() );
       param->setName( outputIt->childId() + ':' + outputIt->name() );
       param->setDescription( outputIt->description() );
-
-      if ( const QgsProcessingDestinationParameter *destParam = dynamic_cast< const QgsProcessingDestinationParameter *>( param.get() ) )
-      {
-        std::unique_ptr< QgsProcessingOutputDefinition > output( destParam->toOutputDefinition() );
-        if ( output )
-        {
-          addOutput( output.release() );
-        }
-      }
       addParameter( param.release() );
     }
   }

diff --git a/src/core/processing/qgsprocessingalgorithm.cpp b/src/core/processing/qgsprocessingalgorithm.cpp
@@ -643,7 +643,6 @@ bool QgsProcessingAlgorithm::createAutoOutputForParameter( QgsProcessingParamete
   if ( !addOutput( output ) )
   {
     // couldn't add output - probably a duplicate name
-    delete output;
     return false;
   }
   else