Speed up message bar operations when many messages are shown

Avoid unnecessary calls to setStyleSheet, which is slow when many message bar items exists Refs #29698
qgis · May 26, 2020 · 5dd29f0 · 5dd29f0
1 parent fbcf39e
commit 5dd29f0
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 5 deletions.
diff --git a/python/gui/auto_generated/qgsmessagebaritem.sip.in b/python/gui/auto_generated/qgsmessagebaritem.sip.in
@@ -96,6 +96,7 @@ has no effect.
 %End
 
   signals:
+
     void styleChanged( const QString &styleSheet );
 %Docstring
 emitted when the message level has changed

diff --git a/src/gui/qgsmessagebar.cpp b/src/gui/qgsmessagebar.cpp
@@ -260,7 +260,13 @@ void QgsMessageBar::showItem( QgsMessageBarItem *item )
   }
 
   connect( mCurrentItem, &QgsMessageBarItem::styleChanged, this, &QWidget::setStyleSheet );
-  setStyleSheet( item->getStyleSheet() );
+
+  if ( item->level() != mPrevLevel )
+  {
+    setStyleSheet( item->getStyleSheet() );
+    mPrevLevel = item->level();
+  }
+
   show();
 
   emit widgetAdded( item );

diff --git a/src/gui/qgsmessagebar.h b/src/gui/qgsmessagebar.h
@@ -164,6 +164,7 @@ class GUI_EXPORT QgsMessageBar: public QFrame
     QTimer *mCountdownTimer = nullptr;
     QProgressBar *mCountProgress = nullptr;
     QString mCountStyleSheet;
+    Qgis::MessageLevel mPrevLevel = Qgis::MessageLevel::None;
 
   private slots:
     //! updates count of items in widget list

diff --git a/src/gui/qgsmessagebaritem.cpp b/src/gui/qgsmessagebaritem.cpp
@@ -220,9 +220,13 @@ QString QgsMessageBarItem::title() const
 
 QgsMessageBarItem *QgsMessageBarItem::setLevel( Qgis::MessageLevel level )
 {
-  mLevel = level;
-  writeContent();
-  emit styleChanged( mStyleSheet );
+  if ( level != mLevel )
+  {
+    mLevel = level;
+    writeContent();
+    emit styleChanged( mStyleSheet );
+  }
+
   return this;
 }
 

diff --git a/src/gui/qgsmessagebaritem.h b/src/gui/qgsmessagebaritem.h
@@ -104,7 +104,10 @@ class GUI_EXPORT QgsMessageBarItem : public QWidget
     void dismiss();
 
   signals:
-    //! emitted when the message level has changed
+
+    /**
+     * emitted when the message level has changed
+     */
     void styleChanged( const QString &styleSheet );
 
   private slots: