add quotes to field name is the rendering order settings dialog (#3270)

(fixes #15203)
qgis · Jul 4, 2016 · 5d4836e · 5d4836e
1 parent 3d0e6e8
commit 5d4836e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/gui/qgsorderbydialog.cpp b/src/gui/qgsorderbydialog.cpp
@@ -58,6 +58,7 @@ QgsFeatureRequest::OrderBy QgsOrderByDialog::orderBy()
   for ( int i = 0; i < mOrderByTableWidget->rowCount(); ++i )
   {
     QString expressionText = static_cast<QgsFieldExpressionWidget*>( mOrderByTableWidget->cellWidget( i, 0 ) )->currentText();
+    bool isExpression = static_cast<QgsFieldExpressionWidget*>( mOrderByTableWidget->cellWidget( i, 0 ) )->isExpression();
 
     if ( ! expressionText.isEmpty() )
     {
@@ -71,6 +72,9 @@ QgsFeatureRequest::OrderBy QgsOrderByDialog::orderBy()
       if ( nullsFirstIndex == 1 )
         nullsFirst = true;
 
+      if ( !isExpression )
+        expressionText = QgsExpression::quotedColumnRef( expressionText );
+
       QgsFeatureRequest::OrderByClause orderByClause( expressionText, asc, nullsFirst );
 
       orderBy << orderByClause;