Add missing SIP_DEPRECATED

nyalldawson · nyalldawson · commit 5c9366605aab · 2018-05-03T16:34:46.000+10:00
diff --git a/python/gui/qgsattributeform.sip.in b/python/gui/qgsattributeform.sip.in
@@ -139,7 +139,7 @@ on all attribute widgets.
 
   signals:
 
- void attributeChanged( const QString &attribute, const QVariant &value );
+ void attributeChanged( const QString &attribute, const QVariant &value ) /Deprecated/;
 %Docstring
 Notifies about changes of attributes
 
diff --git a/src/gui/qgsattributeform.h b/src/gui/qgsattributeform.h
@@ -180,7 +180,7 @@ class GUI_EXPORT QgsAttributeForm : public QWidget
      * \param value     The new value of the attribute.
      * \deprecated since 3.0
      */
-    Q_DECL_DEPRECATED void attributeChanged( const QString &attribute, const QVariant &value );
+    Q_DECL_DEPRECATED void attributeChanged( const QString &attribute, const QVariant &value ) SIP_DEPRECATED;
 
     /**
      * Notifies about changes of attributes

-Original file line number
+Diff line change
   signals:
 - void attributeChanged( const QString &attribute, const QVariant &value );
 + void attributeChanged( const QString &attribute, const QVariant &value ) /Deprecated/;Collapse commentComment on line R142
m-kuhn commented on May 3, 2018 
m-kuhn
on May 3, 2018
Member
Why is that deprecated?
nyalldawson replied on May 3, 2018 
nyalldawson
on May 3, 2018
CollaboratorAuthor
I dunno - I just saw the Q_DECL_DEPRECATED without the companion SIP_DEPRECATED so added it.
3nids replied on May 3, 2018 
3nids
on May 3, 2018
Member
@m-kuhn because you/we decided to do so ;)

https://github.com/qgis/QGIS/pull/6550/files#diff-f0e427f3f984edb5b71b1c1db62a2fecR183
m-kuhn replied on May 3, 2018 
m-kuhn
on May 3, 2018
Member
lol, do you remember why I/we decided to do so? (and why we decided not to leave a comment about replacement in the \deprecated comment?)
3nids replied on May 3, 2018 
3nids
on May 3, 2018
Member
to properly detect changes in the forms (the ones triggers by switching features in attribute table and the ones triggered by the user) and to fix constraint checking when going back to initial value of the field.

We introduced an additional value in the signal to distinguish the reason of widget change.
Code has comments. Press enter to view.
 %Docstring
 Notifies about changes of attributes