[mssql] Don't allow creating connection only when both Host and Provi…

…der/DSN are empty
qgis · Sep 3, 2020 · 5ade7b8 · 5ade7b8
1 parent 7fcb12c
commit 5ade7b8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/providers/mssql/qgsmssqlnewconnection.cpp b/src/providers/mssql/qgsmssqlnewconnection.cpp
@@ -41,6 +41,7 @@ QgsMssqlNewConnection::QgsMssqlNewConnection( QWidget *parent, const QString &co
 
   buttonBox->button( QDialogButtonBox::Ok )->setDisabled( true );
   connect( txtName, &QLineEdit::textChanged, this, &QgsMssqlNewConnection::updateOkButtonState );
+  connect( txtService, &QLineEdit::textChanged, this, &QgsMssqlNewConnection::updateOkButtonState );
   connect( txtHost, &QLineEdit::textChanged, this, &QgsMssqlNewConnection::updateOkButtonState );
   connect( listDatabase, &QListWidget::currentItemChanged, this, &QgsMssqlNewConnection::updateOkButtonState );
 
@@ -252,6 +253,6 @@ void QgsMssqlNewConnection::showHelp()
 void QgsMssqlNewConnection::updateOkButtonState()
 {
   QListWidgetItem *item = listDatabase->currentItem();
-  bool enabled = !txtName->text().isEmpty() && !txtHost->text().isEmpty() && item;
-  buttonBox->button( QDialogButtonBox::Ok )->setEnabled( enabled );
+  bool disabled = txtName->text().isEmpty() || ( txtService->text().isEmpty() && txtHost->text().isEmpty() ) || !item;
+  buttonBox->button( QDialogButtonBox::Ok )->setDisabled( disabled );
 }