Make it easier to drag lower handle exactly to upper handle value and…

… vice versa
qgis · Nov 26, 2020 · 5a8ce2d · 5a8ce2d
1 parent 292a08d
commit 5a8ce2d
Showing 1 changed file with 8 additions and 14 deletions.
diff --git a/src/gui/qgsrangeslider.cpp b/src/gui/qgsrangeslider.cpp
@@ -444,29 +444,23 @@ void QgsRangeSlider::mouseMoveEvent( QMouseEvent *event )
     case Lower:
     {
       // adjust value to account for lower handle click offset
-      newPosition = pixelPosToRangeValue( pick( event->pos() ) - mLowerClickOffset );
-      if ( newPosition <= mUpperValue )
+      newPosition = std::min( mUpperValue, pixelPosToRangeValue( pick( event->pos() ) - mLowerClickOffset ) );
+      if ( mLowerValue != newPosition )
       {
-        if ( mLowerValue != newPosition )
-        {
-          mLowerValue = newPosition;
-          changed = true;
-        }
+        mLowerValue = newPosition;
+        changed = true;
       }
       break;
     }
 
     case Upper:
     {
       // adjust value to account for upper handle click offset
-      newPosition = pixelPosToRangeValue( pick( event->pos() ) - mUpperClickOffset );
-      if ( newPosition >= mLowerValue )
+      newPosition = std::max( mLowerValue, pixelPosToRangeValue( pick( event->pos() ) - mUpperClickOffset ) );
+      if ( mUpperValue != newPosition )
       {
-        if ( mUpperValue != newPosition )
-        {
-          mUpperValue = newPosition;
-          changed = true;
-        }
+        mUpperValue = newPosition;
+        changed = true;
       }
       break;
     }