Better protection agains multiple map drawings with move content tool

mhugent · mhugent · commit 5a27e1b042be · 2008-08-26T11:06:17.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk@9174 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/composer/qgscomposer.h b/src/app/composer/qgscomposer.h
@@ -212,13 +212,6 @@ class QgsComposer: public QMainWindow, private Ui::QgsComposerBase
     /**Etablishes the signal slot connection for the class*/
     void connectSlots();
 
-    /** \brief move up the content of the file
-        \param file file
-    \param from starting position
-    \param shift shift in bytes
-    */
-    bool shiftFileContent( QFile *file, qint64 start, int shift );
-
     //! Set buttons up
     void setToolActionsOff( void );
 
diff --git a/src/app/composer/qgscomposermapwidget.cpp b/src/app/composer/qgscomposermapwidget.cpp
@@ -98,6 +98,11 @@ void QgsComposerMapWidget::on_mPreviewModeComboBox_activated( int i )
     return;
   }
 
+  if(mComposerMap->isDrawing())
+    {
+      return;
+    }
+
   QString comboText = mPreviewModeComboBox->currentText();
   if ( comboText == tr( "Cache" ) )
   {
diff --git a/src/core/composer/qgscomposermap.cpp b/src/core/composer/qgscomposermap.cpp
@@ -100,6 +100,13 @@ void QgsComposerMap::draw( QPainter *painter, const QgsRect& extent, const QSize
     return;
   }
 
+  if ( mDrawing )
+  {
+    return;
+  }
+
+  mDrawing = true;
+
   QgsMapRenderer theMapRenderer;
   theMapRenderer.setExtent( extent );
   theMapRenderer.setOutputSize( size, dpi );
@@ -119,6 +126,8 @@ void QgsComposerMap::draw( QPainter *painter, const QgsRect& extent, const QSize
   theMapRenderer.setScale( scale() );
   theMapRenderer.render( painter );
   theMapRenderer.setScale( bk_scale );
+
+  mDrawing = false;
 }
 
 void QgsComposerMap::cache( void )
@@ -158,18 +167,11 @@ void QgsComposerMap::cache( void )
 
 void QgsComposerMap::paint( QPainter* painter, const QStyleOptionGraphicsItem* itemStyle, QWidget* pWidget )
 {
-  if ( mDrawing )
-  {
-    return;
-  }
-
   if ( !mComposition || !painter )
   {
     return;
   }
 
-  mDrawing = true;
-
   QRectF thisPaintRect = QRectF( 0, 0, QGraphicsRectItem::rect().width(), QGraphicsRectItem::rect().height() );
   painter->save();
   painter->setClipRect( thisPaintRect );
@@ -218,7 +220,6 @@ void QgsComposerMap::paint( QPainter* painter, const QStyleOptionGraphicsItem* i
   painter->restore();
 
   mLastScaleFactorX =  currentScaleFactorX;
-  mDrawing = false;
 }
 
 void QgsComposerMap::mapCanvasChanged( void )
@@ -251,20 +252,23 @@ void QgsComposerMap::resize( double dx, double dy )
 
 void QgsComposerMap::moveContent( double dx, double dy )
 {
-  QRectF itemRect = rect();
-  double xRatio = dx / itemRect.width();
-  double yRatio = dy / itemRect.height();
-
-  double xMoveMapCoord = mExtent.width() * xRatio;
-  double yMoveMapCoord = -( mExtent.height() * yRatio );
-
-  mExtent.setXMinimum( mExtent.xMin() + xMoveMapCoord );
-  mExtent.setXMaximum( mExtent.xMax() + xMoveMapCoord );
-  mExtent.setYmin( mExtent.yMin() + yMoveMapCoord );
-  mExtent.setYmax( mExtent.yMax() + yMoveMapCoord );
-  emit extentChanged();
-  cache();
-  update();
+  if(!mDrawing)
+    {
+      QRectF itemRect = rect();
+      double xRatio = dx / itemRect.width();
+      double yRatio = dy / itemRect.height();
+      
+      double xMoveMapCoord = mExtent.width() * xRatio;
+      double yMoveMapCoord = -( mExtent.height() * yRatio );
+      
+      mExtent.setXMinimum( mExtent.xMin() + xMoveMapCoord );
+      mExtent.setXMaximum( mExtent.xMax() + xMoveMapCoord );
+      mExtent.setYmin( mExtent.yMin() + yMoveMapCoord );
+      mExtent.setYmax( mExtent.yMax() + yMoveMapCoord );
+      emit extentChanged();
+      cache();
+      update();
+    }
 }
 
 void QgsComposerMap::setSceneRect( const QRectF& rectangle )
diff --git a/src/gui/qgscomposerview.cpp b/src/gui/qgscomposerview.cpp
@@ -189,7 +189,6 @@ void QgsComposerView::mouseReleaseEvent( QMouseEvent* e )
         double moveX = scenePoint.x() - mMoveContentStartPos.x();
         double moveY = scenePoint.y() - mMoveContentStartPos.y();
         mMoveContentItem->moveContent( -moveX, -moveY );
-        mMoveContentItem->update();
         mMoveContentItem = 0;
       }
       break;

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,11 @@ void QgsComposerMapWidget::on_mPreviewModeComboBox_activated( int i )`
`98`	`98`	`return;`
`99`	`99`	`}`
`100`	`100`
	`101`	`+ if(mComposerMap->isDrawing())`
	`102`	`+ {`
	`103`	`+ return;`
	`104`	`+ }`
	`105`	`+`
`101`	`106`	`QString comboText = mPreviewModeComboBox->currentText();`
`102`	`107`	`if ( comboText == tr( "Cache" ) )`
`103`	`108`	`{`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,6 @@ void QgsComposerView::mouseReleaseEvent( QMouseEvent* e )`
`189`	`189`	`double moveX = scenePoint.x() - mMoveContentStartPos.x();`
`190`	`190`	`double moveY = scenePoint.y() - mMoveContentStartPos.y();`
`191`	`191`	`mMoveContentItem->moveContent( -moveX, -moveY );`
`192`		`- mMoveContentItem->update();`
`193`	`192`	`mMoveContentItem = 0;`
`194`	`193`	`}`
`195`	`194`	`break;`