Changed to range based for. Also typo

qgis · Apr 4, 2020 · 595b5dc · 595b5dc
1 parent 6aca7b6
commit 595b5dc
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/gui/layertree/qgslayertreeviewdefaultactions.cpp b/src/gui/layertree/qgslayertreeviewdefaultactions.cpp
@@ -437,25 +437,26 @@ void QgsLayerTreeViewDefaultActions::moveOutOfGroup()
 void QgsLayerTreeViewDefaultActions::moveToTop()
 {
   QList< QgsLayerTreeNode * >  selectedNodes = mView->selectedNodes();
-  // sort the nodes by depth first to avoid moving a group before it's contents
+  std::reverse( selectedNodes.begin(), selectedNodes.end() );
+  // sort the nodes by depth first to avoid moving a group before its contents
   std::stable_sort( selectedNodes.begin(), selectedNodes.end(), []( const QgsLayerTreeNode * a, const QgsLayerTreeNode * b )
   {
-    return a->depth() < b->depth();
+    return a->depth() > b->depth();
   } );
-  for ( auto it = selectedNodes.rbegin(); it < selectedNodes.rend(); ++it )
+  for ( QgsLayerTreeNode *n : qgis::as_const( selectedNodes ) )
   {
-    QgsLayerTreeGroup *parentGroup = qobject_cast<QgsLayerTreeGroup *>( ( *it )->parent() );
-    QgsLayerTreeNode *clonedNode = ( *it )->clone();
+    QgsLayerTreeGroup *parentGroup = qobject_cast<QgsLayerTreeGroup *>( n->parent() );
+    QgsLayerTreeNode *clonedNode = n->clone();
     parentGroup->insertChildNode( 0, clonedNode );
-    parentGroup->removeChildNode( ( *it ) );
+    parentGroup->removeChildNode( n );
   }
 }
 
 
 void QgsLayerTreeViewDefaultActions::moveToBottom()
 {
   QList< QgsLayerTreeNode * > selectedNodes = mView->selectedNodes();
-  // sort the nodes by depth first to avoid moving a group before it's contents
+  // sort the nodes by depth first to avoid moving a group before its contents
   std::stable_sort( selectedNodes.begin(), selectedNodes.end(), []( const QgsLayerTreeNode * a, const QgsLayerTreeNode * b )
   {
     return a->depth() > b->depth();