Navigation Menu

Skip to content

Commit

Permalink
Hopefully fix sld test
Browse files Browse the repository at this point in the history
  • Loading branch information
@mhugent
mhugent committed Nov 18, 2014
1 parent d7f7b06 commit 5957b0a
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/core/symbology-ng/qgssymbollayerv2utils.cpp
View file
Expand Up @@ -2438,13 +2438,8 @@ bool QgsSymbolLayerV2Utils::createFunctionElement( QDomDocument &doc, QDomElemen

bool QgsSymbolLayerV2Utils::functionFromSldElement( QDomElement &element, QString &function )
{
QgsDebugMsg( "Entered." );
QDomElement elem;
if ( element.tagName() == "Filter" )
{
elem = element;
}
else
QDomElement elem = element;
if ( element.tagName() != "Filter" )
{
QDomNodeList filterNodes = element.elementsByTagName( "Filter" );
if ( filterNodes.size() > 0 )
Expand Down

3 comments on commit 5957b0a

@m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented on 5957b0a Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhugent
Can you update the .travis.yml file that this test is no longer excluded (see m-kuhn@7ae4a36)
Best to create a pull request if there's a "hopefully" in the commit message. Then you see the test result before it's merged to master.

@mhugent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it also possible to see the test results for commits or only for pull request?

@m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented on 5957b0a Nov 18, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.