Skip to content

Commit 56a7702

Browse files
committedSep 14, 2014
Keep log button in status bar.
Removing UI elements under the user isn't good UX
1 parent c076b30 commit 56a7702

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed
 

‎src/gui/qgsmessagelogviewer.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ QgsMessageLogViewer::QgsMessageLogViewer( QStatusBar *statusBar, QWidget *parent
6363
mButton->setToolTip( tr( "No messages." ) );
6464
#endif
6565
mButton->setCheckable( true );
66-
mButton->hide();
6766
connect( mButton, SIGNAL( toggled( bool ) ), this, SLOT( buttonToggled( bool ) ) );
6867
connect( mButton, SIGNAL( destroyed() ), this, SLOT( buttonDestroyed() ) );
6968
statusBar->addPermanentWidget( mButton, 0 );
@@ -89,7 +88,6 @@ void QgsMessageLogViewer::showEvent( QShowEvent * )
8988
if ( mButton )
9089
{
9190
mButton->setChecked( true );
92-
mButton->hide();
9391
}
9492
}
9593

2 commit comments

Comments
 (2)

nyalldawson commented on Sep 14, 2014

@nyalldawson
Collaborator

@NathanW2 I understand the rationale behind this change, but it's a bit alarming to always have a yellow exclamation visible on the status bar. Do we even need this button here at all? Could we remove the button and leave the panel accessible only via the menu item?
Alternatively, maybe we need two icons - one grayscale, faded icon for when there's nothing to alert the user in the log, and a second yellow icon which only shows when there's an error in the log?

NathanW2 commented on Sep 14, 2014

@NathanW2
MemberAuthor
Please sign in to comment.