Skip to content

Commit

Permalink
Keep log button in status bar.
Browse files Browse the repository at this point in the history 
Removing UI elements under the user isn't good UX
  • Loading branch information
@NathanW2
NathanW2 committed Sep 14, 2014
1 parent c076b30 commit 56a7702
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/gui/qgsmessagelogviewer.cpp
View file
Expand Up @@ -63,7 +63,6 @@ QgsMessageLogViewer::QgsMessageLogViewer( QStatusBar *statusBar, QWidget *parent
mButton->setToolTip( tr( "No messages." ) );
#endif
mButton->setCheckable( true );
mButton->hide();
connect( mButton, SIGNAL( toggled( bool ) ), this, SLOT( buttonToggled( bool ) ) );
connect( mButton, SIGNAL( destroyed() ), this, SLOT( buttonDestroyed() ) );
statusBar->addPermanentWidget( mButton, 0 );
Expand All @@ -89,7 +88,6 @@ void QgsMessageLogViewer::showEvent( QShowEvent * )
if ( mButton )
{
mButton->setChecked( true );
mButton->hide();
}
}

Expand Down

2 comments on commit 56a7702

@nyalldawson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NathanW2 I understand the rationale behind this change, but it's a bit alarming to always have a yellow exclamation visible on the status bar. Do we even need this button here at all? Could we remove the button and leave the panel accessible only via the menu item?
Alternatively, maybe we need two icons - one grayscale, faded icon for when there's nothing to alert the user in the log, and a second yellow icon which only shows when there's an error in the log?

@NathanW2
Copy link
Member Author

@NathanW2 NathanW2 commented on 56a7702 Sep 14, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.