Skip to content

Commit

Permalink
Some doxygen grammar fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Oct 20, 2020
1 parent d3adc10 commit 5565a68
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 17 deletions.
5 changes: 3 additions & 2 deletions python/core/auto_generated/qgscacheindex.sip.in
Expand Up @@ -29,7 +29,7 @@ Constructor for QgsAbstractCacheIndex.

virtual void flushFeature( QgsFeatureId fid ) = 0;
%Docstring
Is called, whenever a feature is removed from the cache. You should update your indexes, so
Is called whenever a feature is removed from the cache. You should update your indexes so
they become invalid in case this feature was required to successfully answer a request.
%End

Expand All @@ -51,7 +51,8 @@ Does nothing by default

virtual bool getCacheIterator( QgsFeatureIterator &featureIterator, const QgsFeatureRequest &featureRequest ) = 0;
%Docstring
Is called, when a feature request is issued on a cached layer.
Is called when a feature request is issued on a cached layer.

If this cache index is able to completely answer the feature request, it will return ``True``
and set the iterator to a valid iterator over the cached features. If it is not able
it will return ``False``.
Expand Down
Expand Up @@ -291,7 +291,7 @@ Is forwarded to the slot :py:func:`~QgsEditorWidgetWrapper.setValues`

virtual void setValue( const QVariant &value ) /Deprecated/;
%Docstring
Is called, when the value of the widget needs to be changed. Update the widget representation
Is called when the value of the widget needs to be changed. Updates the widget representation
to reflect the new value.

:param value: The new value of the attribute
Expand All @@ -302,8 +302,8 @@ to reflect the new value.

void setValues( const QVariant &value, const QVariantList &additionalValues );
%Docstring
Is called, when the value of the widget or additional field values
needs to be changed. Update the widget representation
Is called when the value of the widget or additional field values
needs to be changed. Updates the widget representation
to reflect the new values.

.. versionadded:: 3.10
Expand Down
Expand Up @@ -211,7 +211,7 @@ This method should initialize the editor widget with runtime data. Fill your com

virtual void setFeature( const QgsFeature &feature ) = 0;
%Docstring
Is called, when the value of the widget needs to be changed. Update the widget representation
Is called when the value of the widget needs to be changed. Updates the widget representation
to reflect the new value.

:param feature: The new feature
Expand Down
2 changes: 1 addition & 1 deletion python/gui/auto_generated/qgisinterface.sip.in
Expand Up @@ -1526,7 +1526,7 @@ Emitted when a project file is successfully read.
.. note::

This is useful for plugins that store properties with project files.
A plugin can connect to this signal. When it is emitted, the plugin
A plugin can connect to this signal. When it is emitted the plugin
knows to then check the project properties for any relevant state.
%End

Expand Down
5 changes: 3 additions & 2 deletions src/core/qgscacheindex.h
Expand Up @@ -39,7 +39,7 @@ class CORE_EXPORT QgsAbstractCacheIndex
virtual ~QgsAbstractCacheIndex() = default;

/**
* Is called, whenever a feature is removed from the cache. You should update your indexes, so
* Is called whenever a feature is removed from the cache. You should update your indexes so
* they become invalid in case this feature was required to successfully answer a request.
*/
virtual void flushFeature( QgsFeatureId fid ) = 0;
Expand All @@ -62,7 +62,8 @@ class CORE_EXPORT QgsAbstractCacheIndex
virtual void requestCompleted( const QgsFeatureRequest &featureRequest, const QgsFeatureIds &fids );

/**
* Is called, when a feature request is issued on a cached layer.
* Is called when a feature request is issued on a cached layer.
*
* If this cache index is able to completely answer the feature request, it will return TRUE
* and set the iterator to a valid iterator over the cached features. If it is not able
* it will return FALSE.
Expand Down
4 changes: 2 additions & 2 deletions src/core/qgsvectorlayer.h
Expand Up @@ -2392,7 +2392,7 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer, public QgsExpressionConte
* to do in order to be able to save the changes.
* - to set the property back to TRUE, once the user has fixed his data.
*
* When calling \see commitChanges(), this flag is checked just after the
* When calling \see commitChanges() this flag is checked just after the
* \see beforeCommitChanges() signal is emitted, so it's possible to adjust it from there.
*
* \note Not available in Python bindings
Expand All @@ -2411,7 +2411,7 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer, public QgsExpressionConte
* to do in order to be able to save the changes.
* - to set the property back to TRUE, once the user has fixed his data.
*
* When calling \see commitChanges(), this flag is checked just after the
* When calling \see commitChanges() this flag is checked just after the
* \see beforeCommitChanges() signal is emitted, so it's possible to adjust it from there.
*
* \note Not available in Python bindings
Expand Down
8 changes: 4 additions & 4 deletions src/gui/editorwidgets/core/qgseditorwidgetwrapper.h
Expand Up @@ -286,7 +286,7 @@ class GUI_EXPORT QgsEditorWidgetWrapper : public QgsWidgetWrapper
// TODO Q_DECL_DEPRECATED

/**
* Is called, when the value of the widget needs to be changed. Update the widget representation
* Is called when the value of the widget needs to be changed. Updates the widget representation
* to reflect the new value.
*
* \param value The new value of the attribute
Expand All @@ -295,8 +295,8 @@ class GUI_EXPORT QgsEditorWidgetWrapper : public QgsWidgetWrapper
virtual void setValue( const QVariant &value ) SIP_DEPRECATED;

/**
* Is called, when the value of the widget or additional field values
* needs to be changed. Update the widget representation
* Is called when the value of the widget or additional field values
* needs to be changed. Updates the widget representation
* to reflect the new values.
* \since QGIS 3.10
*/
Expand Down Expand Up @@ -364,7 +364,7 @@ class GUI_EXPORT QgsEditorWidgetWrapper : public QgsWidgetWrapper
private:

/**
* Is called, when the value of the widget needs to be changed. Update the widget representation
* Is called when the value of the widget needs to be changed. Updates the widget representation
* to reflect the new value.
*
* \param value The new value of the attribute
Expand Down
2 changes: 1 addition & 1 deletion src/gui/editorwidgets/core/qgswidgetwrapper.h
Expand Up @@ -247,7 +247,7 @@ class GUI_EXPORT QgsWidgetWrapper : public QObject
public slots:

/**
* Is called, when the value of the widget needs to be changed. Update the widget representation
* Is called when the value of the widget needs to be changed. Updates the widget representation
* to reflect the new value.
*
* \param feature The new feature
Expand Down
2 changes: 1 addition & 1 deletion src/gui/qgisinterface.h
Expand Up @@ -1260,7 +1260,7 @@ class GUI_EXPORT QgisInterface : public QObject
/**
* Emitted when a project file is successfully read.
* \note This is useful for plugins that store properties with project files.
* A plugin can connect to this signal. When it is emitted, the plugin
* A plugin can connect to this signal. When it is emitted the plugin
* knows to then check the project properties for any relevant state.
*/
void projectRead();
Expand Down

0 comments on commit 5565a68

Please sign in to comment.