Skip to content

Commit

Permalink
[Style Dock] Only disable the widget and not the dock
Browse files Browse the repository at this point in the history
  • Loading branch information
@NathanW2
NathanW2 committed May 11, 2016
1 parent ab288c6 commit 54e6eb3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/app/qgisapp.cpp
View file
Expand Up @@ -5532,11 +5532,11 @@ void QgisApp::setMapStyleDockLayer( QgsMapLayer* layer )
{
if ( !layer )
{
mMapStylingDock->setEnabled( false );
mMapStyleWidget->setEnabled( false );
return;
}

mMapStylingDock->setEnabled( true );
mMapStyleWidget->setEnabled( true );
// We don't set the layer if the dock isn't open mainly to save
// the extra work if it's not needed
if ( mMapStylingDock->isVisible() )
Expand Down

4 comments on commit 54e6eb3

@3nids
Copy link
Member

@3nids 3nids commented on 54e6eb3 May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've done a great job Nathan, thanks a lot for this.

One minor thing, once edited a symbol of a rule, other symbols get disabled and I can't edit the style anymore. I need to switch layer and back.

image

Do you have an idea?

@NathanW2
Copy link
Member Author

@NathanW2 NathanW2 commented on 54e6eb3 May 11, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3nids
Copy link
Member

@3nids 3nids commented on 54e6eb3 May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently, it's when I clicked a symbol in the legend entry. There is no more current layer selected in the legend, although the dock stays enabled. Whenever I change something, it probably looks for the active layer but there is no one.

@NathanW2
Copy link
Member Author

@NathanW2 NathanW2 commented on 54e6eb3 May 11, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.