Properly set invalid topology layer as invalid

Sandro Santilli · Sandro Santilli · commit 54cf972ac233 · 2015-11-06T21:37:22.000+01:00
Fixes #13781 (crash)
diff --git a/src/providers/postgres/qgspostgresprovider.cpp b/src/providers/postgres/qgspostgresprovider.cpp
@@ -128,11 +128,15 @@ QgsPostgresProvider::QgsPostgresProvider( QString const & uri )
     return;
   }
 
+  // NOTE: mValid would be true after true return from
+  // getGeometryDetails, see http://hub.qgis.org/issues/13781
+
   if ( mSpatialColType == sctTopoGeometry )
   {
     if ( !getTopoLayerInfo() ) // gets topology name and layer id
     {
       QgsMessageLog::logMessage( tr( "invalid PostgreSQL topology layer" ), tr( "PostGIS" ) );
+      mValid = false;
       disconnectDb();
       return;
     }

Original file line number	Diff line number	Diff line change
`@@ -128,11 +128,15 @@ QgsPostgresProvider::QgsPostgresProvider( QString const & uri )`
`128`	`128`	`return;`
`129`	`129`	`}`
`130`	`130`
	`131`	`+ // NOTE: mValid would be true after true return from`
	`132`	`+ // getGeometryDetails, see http://hub.qgis.org/issues/13781`
	`133`	`+`
`131`	`134`	`if ( mSpatialColType == sctTopoGeometry )`
`132`	`135`	`{`
`133`	`136`	`if ( !getTopoLayerInfo() ) // gets topology name and layer id`
`134`	`137`	`{`
`135`	`138`	`QgsMessageLog::logMessage( tr( "invalid PostgreSQL topology layer" ), tr( "PostGIS" ) );`
	`139`	`+ mValid = false;`
`136`	`140`	`disconnectDb();`
`137`	`141`	`return;`
`138`	`142`	`}`