[Fix #7772] Check attribute index before setting attribute to avoid crash

m-kuhn · m-kuhn · commit 524e142e1178 · 2013-05-07T07:48:06.000+02:00
diff --git a/src/core/qgsfeature.cpp b/src/core/qgsfeature.cpp
@@ -184,13 +184,11 @@ void QgsFeature::initAttributes( int fieldCount )
 
 bool QgsFeature::setAttribute( int idx, const QVariant &value )
 {
-#ifdef QGISDEBUG
   if ( idx < 0 || idx >= mAttributes.size() )
   {
     QgsMessageLog::logMessage( QObject::tr( "Attribute index %1 out of bounds [0;%2[" ).arg( idx ).arg( mAttributes.size() ), QString::null, QgsMessageLog::WARNING );
     return false;
   }
-#endif
 
   mAttributes[idx] = value;
   return true;

Original file line number	Diff line number	Diff line change
`@@ -184,13 +184,11 @@ void QgsFeature::initAttributes( int fieldCount )`
`184`	`184`
`185`	`185`	`bool QgsFeature::setAttribute( int idx, const QVariant &value )`
`186`	`186`	`{`
`187`		`-#ifdef QGISDEBUG`
`188`	`187`	`if ( idx < 0 \|\| idx >= mAttributes.size() )`
`189`	`188`	`{`
`190`	`189`	`QgsMessageLog::logMessage( QObject::tr( "Attribute index %1 out of bounds [0;%2[" ).arg( idx ).arg( mAttributes.size() ), QString::null, QgsMessageLog::WARNING );`
`191`	`190`	`return false;`
`192`	`191`	`}`
`193`		`-#endif`
`194`	`192`
`195`	`193`	`mAttributes[idx] = value;`
`196`	`194`	`return true;`