[processing] make Modeller non-blocking window

alexbruy · alexbruy · commit 51ec2bfba6cd · 2016-01-20T14:51:04.000+02:00
diff --git a/python/plugins/processing/ProcessingPlugin.py b/python/plugins/processing/ProcessingPlugin.py
@@ -147,6 +147,7 @@ def openToolbox(self):
 
     def openModeler(self):
         dlg = ModelerDialog()
+        dlg.show()
         dlg.exec_()
         if dlg.update:
             self.toolbox.updateProvider('model')

-Original file line number
+Diff line change
     def openModeler(self):
         dlg = ModelerDialog()
 +        dlg.show()
         dlg.exec_()Collapse commentComment on line R151
m-kuhn commented on Jan 20, 2016 
m-kuhn
on Jan 20, 2016
Member
Shouldn't the exec call be removed? According to the doc, this makes it modal.
alexbruy replied on Jan 20, 2016 
alexbruy
on Jan 20, 2016
ContributorAuthor
If exec_() removed than dialog does not displayed. Currently Modeller and Resuls dialogs are non-modal and don't block QGIS main window.
m-kuhn replied on Jan 20, 2016 
m-kuhn
on Jan 20, 2016
Member
Strange, QDialogs behave differently when I create them in a python console, but as long as it works ...
SebDieBln replied on Jan 20, 2016 
SebDieBln
on Jan 20, 2016
Contributor
@alexbruy

dialog is not displayed

Did you take into account that dlg is a local variable and as such is deleted as soon as openModeler() finishes?
I recently had to fix the same mistake for one of our plugins at work, too 😄
@m-kuhn

but as long as it works

Hm, I don't quite concur. But that would be off-topic here.
Code has comments. Press enter to view.
         if dlg.update:
             self.toolbox.updateProvider('model')