Merge pull request #2894 from rouault/fix_spatialite_insert

Fix spatialite insert
qgis · Mar 12, 2016 · 51d6f5f · 51d6f5f
2 parents 9167e1b + b253a29
commit 51d6f5f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/core/qgsslconnect.cpp b/src/core/qgsslconnect.cpp
@@ -14,6 +14,7 @@
  ***************************************************************************/
 
 #include "qgsslconnect.h"
+#include "qgslogger.h"
 
 #include <sqlite3.h>
 #include <spatialite.h>
@@ -52,6 +53,11 @@ int QgsSLConnect::sqlite3_close( sqlite3 *db )
     spatialite_cleanup_ex( mSLconns.take( db ) );
 #endif
 
+  if ( res != SQLITE_OK )
+  {
+    QgsDebugMsg( QString( "sqlite3_close() failed: %1" ).arg( res ) );
+  }
+
   return res;
 }
 
@@ -85,5 +91,10 @@ int QgsSLConnect::sqlite3_close_v2( sqlite3 *db )
     spatialite_cleanup_ex( mSLconns.take( db ) );
 #endif
 
+  if ( res != SQLITE_OK )
+  {
+    QgsDebugMsg( QString( "sqlite3_close() failed: %1" ).arg( res ) );
+  }
+
   return res;
 }
diff --git a/src/providers/spatialite/qgsspatialiteprovider.cpp b/src/providers/spatialite/qgsspatialiteprovider.cpp
@@ -3748,6 +3748,9 @@ bool QgsSpatiaLiteProvider::addFeatures( QgsFeatureList & flist )
           break;
         }
       }
+
+      sqlite3_finalize( stmt );
+
       if ( ret == SQLITE_DONE || ret == SQLITE_ROW )
       {
         ret = sqlite3_exec( sqliteHandle, "COMMIT", nullptr, nullptr, &errMsg );