feature actions: new "Open" action type to open urls in the default web browser and files with a suitable application

brushtyler · brushtyler · commit 516fc7eb2d00 · 2012-03-28T03:26:45.000+02:00
diff --git a/src/app/qgsattributeactiondialog.cpp b/src/app/qgsattributeactiondialog.cpp
@@ -329,6 +329,8 @@ void QgsAttributeActionDialog::addDefaultActions()
   insertRow( pos++, QgsAction::GenericPython, tr( "Get feature id" ), "QtGui.QMessageBox.information(None, \"Feature id\", \"feature id is [% $id %]\")", false );
   insertRow( pos++, QgsAction::GenericPython, tr( "Selected field's value (Identify features tool)" ), "QtGui.QMessageBox.information(None, \"Current field's value\", \"[% $currentfield %]\")", false );
   insertRow( pos++, QgsAction::GenericPython, tr( "Clicked coordinates (Run feature actions tool)" ), "QtGui.QMessageBox.information(None, \"Clicked coords\", \"layer: [% $layerid %]\\ncoords: ([% $clickx %],[% $clickx %])\")", false );
+  insertRow( pos++, QgsAction::OpenUrl, tr( "Open file" ), "[% \"PATH\" %]", false );
+  insertRow( pos++, QgsAction::OpenUrl, tr( "Search on web based on attribute's value" ), "http://www.google.it/?q=[% \"ATTRIBUTE\" %]", false );
 }
 
 void QgsAttributeActionDialog::itemSelectionChanged()
diff --git a/src/core/qgsattributeaction.cpp b/src/core/qgsattributeaction.cpp
@@ -106,7 +106,15 @@ void QgsAttributeAction::doAction( int index, QgsFeature &feat,
 
 void QgsAttributeAction::runAction( const QgsAction &action, void ( *executePython )( const QString & ) )
 {
-  if ( action.type() == QgsAction::GenericPython )
+  if ( action.type() == QgsAction::OpenUrl )
+  {
+    QFileInfo finfo( action.action() );
+    if ( finfo.exists() && finfo.isFile() )
+      QDesktopServices::openUrl( QUrl::fromLocalFile( action.action() ) );
+    else
+      QDesktopServices::openUrl( QUrl( action.action(), QUrl::TolerantMode ) );
+  }
+  else if ( action.type() == QgsAction::GenericPython )
   {
     if ( executePython )
     {
diff --git a/src/core/qgsattributeaction.h b/src/core/qgsattributeaction.h
@@ -47,6 +47,7 @@ class CORE_EXPORT QgsAction
       Mac,
       Windows,
       Unix,
+      OpenUrl,
     };
 
     QgsAction( ActionType type, QString name, QString action, bool capture ) :
@@ -69,6 +70,7 @@ class CORE_EXPORT QgsAction
     {
       return mType == Generic ||
              mType == GenericPython ||
+             mType == OpenUrl ||
 #if defined(Q_OS_WIN)
              mType == Windows
 #elif defined(Q_OS_MAC)
diff --git a/src/ui/qgsattributeactiondialogbase.ui b/src/ui/qgsattributeactiondialogbase.ui
@@ -159,6 +159,11 @@
             <string>Unix</string>
            </property>
           </item>
+          <item>
+           <property name="text">
+            <string>Open</string>
+           </property>
+          </item>
          </widget>
         </item>
         <item>

Original file line number	Diff line number	Diff line change
`@@ -329,6 +329,8 @@ void QgsAttributeActionDialog::addDefaultActions()`
`329`	`329`	`insertRow( pos++, QgsAction::GenericPython, tr( "Get feature id" ), "QtGui.QMessageBox.information(None, \"Feature id\", \"feature id is [% $id %]\")", false );`
`330`	`330`	`insertRow( pos++, QgsAction::GenericPython, tr( "Selected field's value (Identify features tool)" ), "QtGui.QMessageBox.information(None, \"Current field's value\", \"[% $currentfield %]\")", false );`
`331`	`331`	`insertRow( pos++, QgsAction::GenericPython, tr( "Clicked coordinates (Run feature actions tool)" ), "QtGui.QMessageBox.information(None, \"Clicked coords\", \"layer: [% $layerid %]\\ncoords: ([% $clickx %],[% $clickx %])\")", false );`
	`332`	`+ insertRow( pos++, QgsAction::OpenUrl, tr( "Open file" ), "[% \"PATH\" %]", false );`
	`333`	`+ insertRow( pos++, QgsAction::OpenUrl, tr( "Search on web based on attribute's value" ), "http://www.google.it/?q=[% \"ATTRIBUTE\" %]", false );`
`332`	`334`	`}`
`333`	`335`
`334`	`336`	`void QgsAttributeActionDialog::itemSelectionChanged()`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,15 @@ void QgsAttributeAction::doAction( int index, QgsFeature &feat,`
`106`	`106`
`107`	`107`	`void QgsAttributeAction::runAction( const QgsAction &action, void ( *executePython )( const QString & ) )`
`108`	`108`	`{`
`109`		`- if ( action.type() == QgsAction::GenericPython )`
	`109`	`+ if ( action.type() == QgsAction::OpenUrl )`
	`110`	`+ {`
	`111`	`+ QFileInfo finfo( action.action() );`
	`112`	`+ if ( finfo.exists() && finfo.isFile() )`
	`113`	`+ QDesktopServices::openUrl( QUrl::fromLocalFile( action.action() ) );`
	`114`	`+ else`
	`115`	`+ QDesktopServices::openUrl( QUrl( action.action(), QUrl::TolerantMode ) );`
	`116`	`+ }`
	`117`	`+ else if ( action.type() == QgsAction::GenericPython )`
`110`	`118`	`{`
`111`	`119`	`if ( executePython )`
`112`	`120`	`{`