Sip updates for source select provider and registry

qgis · Sep 4, 2017 · 50e0a01 · 50e0a01
1 parent 2d073d6
commit 50e0a01
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/python/gui/qgssourceselectprovider.sip b/python/gui/qgssourceselectprovider.sip
@@ -59,7 +59,7 @@ Text for the menu item entry, it will be visible to the user so make sure it's t
  :rtype: int
 %End
 
-    virtual QgsAbstractDataSourceWidget *createDataSourceWidget( QWidget *parent = 0 ) const = 0 /Factory/;
+    virtual QgsAbstractDataSourceWidget *createDataSourceWidget( QWidget *parent = 0, Qt::WindowFlags fl = Qt::Widget, QgsProviderRegistry::WidgetMode widgetMode = QgsProviderRegistry::WidgetMode::Embedded ) const = 0 /Factory/;
 %Docstring
  Create a new instance of QgsAbstractDataSourceWidget (or null).
  Caller takes responsibility of deleting created.

diff --git a/python/gui/qgssourceselectproviderregistry.sip b/python/gui/qgssourceselectproviderregistry.sip
@@ -43,23 +43,24 @@ Get list of available providers
 
     void addProvider( QgsSourceSelectProvider *provider /Transfer/ );
 %Docstring
-Add a provider implementation. Takes ownership of the object.
+Add a ``provider`` implementation. Takes ownership of the object.
 %End
 
-    void removeProvider( QgsSourceSelectProvider *provider );
+    bool removeProvider( QgsSourceSelectProvider *provider /Transfer/ );
 %Docstring
-Remove provider implementation from the list (provider object is deleted)
+:return: true if the provider was actually removed and deleted
+ :rtype: bool
 %End
 
     QgsSourceSelectProvider *providerByName( const QString &name );
 %Docstring
-Return a provider by name or None if not found
+Return a provider by ``name`` or None if not found
  :rtype: QgsSourceSelectProvider
 %End
 
     QList<QgsSourceSelectProvider *> providersByKey( const QString &providerKey );
 %Docstring
-Return a (possibly empty) list of providers by data provider's key
+Return a (possibly empty) list of providers by data ``providerkey``
  :rtype: list of QgsSourceSelectProvider
 %End