Prevent flooding (and app freeze) of items added to the message bar

qgis · Oct 31, 2018 · 4d33422 · 4d33422
1 parent f5a1b4e
commit 4d33422
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/src/gui/qgsmessagebar.cpp b/src/gui/qgsmessagebar.cpp
@@ -298,6 +298,17 @@ QgsMessageBarItem *QgsMessageBar::pushWidget( QWidget *widget, Qgis::MessageLeve
 
 void QgsMessageBar::pushMessage( const QString &title, const QString &text, Qgis::MessageLevel level, int duration )
 {
+  // keep the number of items in the message bar to a maximum of 20, avoids flooding (and freezing) of the main window
+  if ( mItems.count() > 20 )
+    mItems.removeFirst();
+
+  // block duplicate items, avoids flooding (and freezing) of the main window
+  for ( auto it = mItems.constBegin(); it != mItems.constEnd(); ++it )
+  {
+    if ( level == ( *it )->level() && title == ( *it )->title() && text == ( *it )->text() )
+      return;
+  }
+
   QgsMessageBarItem *item = new QgsMessageBarItem( title, text, level, duration );
   pushItem( item );
 }