Removed unused QgsFeature::isDirty() and QgsFeature::clean()

qgis · Oct 13, 2012 · 4bc60ff · 4bc60ff
1 parent eb6d4d3
commit 4bc60ff
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 42 deletions.
diff --git a/python/core/qgsfeature.sip b/python/core/qgsfeature.sip
@@ -147,18 +147,6 @@ class QgsFeature
      */
     void setValid( bool validity );
 
-    /**
-     * Return the dirty state of this feature.
-     * Dirty is set if (e.g.) the feature's geometry has been modified in-memory.
-     */
-    bool isDirty() const;
-
-    /**
-     * Reset the dirtiness of the feature.  (i.e. make clean)
-     * You would normally do this after it's saved to permanent storage (e.g. disk, an ACID-compliant database)
-     */
-    void clean();
-
     /**
      * Get the geometry object associated with this feature
      */

diff --git a/src/core/qgsfeature.cpp b/src/core/qgsfeature.cpp
@@ -27,7 +27,6 @@ QgsFeature::QgsFeature( QgsFeatureId id )
     , mGeometry( 0 )
     , mOwnsGeometry( 0 )
     , mValid( false )
-    , mDirty( 0 )
     , mFields( 0 )
 {
   // NOOP
@@ -39,7 +38,6 @@ QgsFeature::QgsFeature( QgsFeature const & rhs )
     , mGeometry( 0 )
     , mOwnsGeometry( false )
     , mValid( rhs.mValid )
-    , mDirty( rhs.mDirty )
     , mFields( rhs.mFields )
 {
 
@@ -57,7 +55,6 @@ QgsFeature & QgsFeature::operator=( QgsFeature const & rhs )
     return *this;
 
   mFid =  rhs.mFid;
-  mDirty =  rhs.mDirty;
   mAttributes =  rhs.mAttributes;
   mValid =  rhs.mValid;
   mFields = rhs.mFields;
@@ -195,17 +192,6 @@ void QgsFeature::setValid( bool validity )
   mValid = validity;
 }
 
-bool QgsFeature::isDirty() const
-{
-  return mDirty;
-}
-
-void QgsFeature::clean()
-{
-  mDirty = false;
-}
-
-
 bool QgsFeature::addAttribute( const QString& name, QVariant value )
 {
   int fieldIdx = fieldNameIndex( name );

diff --git a/src/core/qgsfeature.h b/src/core/qgsfeature.h
@@ -169,18 +169,6 @@ class CORE_EXPORT QgsFeature
      */
     void setValid( bool validity );
 
-    /**
-     * Return the dirty state of this feature.
-     * Dirty is set if (e.g.) the feature's geometry has been modified in-memory.
-     */
-    bool isDirty() const;
-
-    /**
-     * Reset the dirtiness of the feature.  (i.e. make clean)
-     * You would normally do this after it's saved to permanent storage (e.g. disk, an ACID-compliant database)
-     */
-    void clean();
-
     /**
      * Get the geometry object associated with this feature
      */
@@ -271,10 +259,6 @@ class CORE_EXPORT QgsFeature
     // TODO: still applies? [MD]
     bool mValid;
 
-    //! Flag to indicate if this feature is dirty (e.g. geometry has been modified in-memory)
-    // TODO: still applies? [MD]
-    bool mDirty;
-
     //! Optional field map for name-based attribute lookups
     const QgsFieldMap* mFields;