Added test cases for split features tool

qgis · Sep 4, 2020 · 4a668fc · 4a668fc
1 parent bc76b2c
commit 4a668fc
Show file tree

Hide file tree

Showing 2 changed files with 254 additions and 0 deletions.
diff --git a/tests/src/app/CMakeLists.txt b/tests/src/app/CMakeLists.txt
@@ -133,6 +133,7 @@ ADD_QGIS_TEST(maptoolellipsetest testqgsmaptoolellipse.cpp)
 ADD_QGIS_TEST(maptoolrectangletest testqgsmaptoolrectangle.cpp)
 ADD_QGIS_TEST(maptoolregularpolygontest testqgsmaptoolregularpolygon.cpp)
 ADD_QGIS_TEST(maptoolsplitpartstest testqgsmaptoolsplitparts.cpp)
+ADD_QGIS_TEST(maptoolsplitfeaturestest testqgsmaptoolsplitfeatures.cpp)
 ADD_QGIS_TEST(measuretool testqgsmeasuretool.cpp)
 ADD_QGIS_TEST(vertextool testqgsvertextool.cpp)
 ADD_QGIS_TEST(vectorlayersaveasdialogtest testqgsvectorlayersaveasdialog.cpp)

diff --git a/tests/src/app/testqgsmaptoolsplitfeatures.cpp b/tests/src/app/testqgsmaptoolsplitfeatures.cpp
@@ -0,0 +1,253 @@
+/***************************************************************************
+     testqgsmaptoolsplitfeatures.cpp
+     ------------------------
+    Date                 : August 2020
+    Copyright            : (C) 2020 by Stefanos Natsis
+    Email                : uclaros@gmail.com
+ ***************************************************************************
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ ***************************************************************************/
+
+#include "qgstest.h"
+
+#include "qgisapp.h"
+#include "qgsgeometry.h"
+#include "qgsmapcanvas.h"
+#include "qgssettings.h"
+#include "qgsvectorlayer.h"
+#include "qgsmaptoolsplitfeatures.h"
+#include "qgsgeometryutils.h"
+
+#include "testqgsmaptoolutils.h"
+
+class TestQgsMapToolSplitFeatures : public QObject
+{
+    Q_OBJECT
+
+  public:
+    TestQgsMapToolSplitFeatures();
+
+  private slots:
+    void initTestCase();
+    void cleanupTestCase();
+
+    void testNoFeaturesSplit();
+    void testSplitPolygon();
+    void testSplitPolygonTopologicalEditing();
+
+  private:
+    QPoint mapToPoint( double x, double y );
+    QgisApp *mQgisApp = nullptr;
+    QgsMapCanvas *mCanvas = nullptr;
+    QgsVectorLayer *mMultiLineStringLayer = nullptr;
+    QgsVectorLayer *mPolygonLayer = nullptr;
+    QgsVectorLayer *mMultiPolygonLayer = nullptr;
+    QgsFeature lineF1, lineF2, polygonF1, polygonF2, multipolygonF1;
+};
+
+TestQgsMapToolSplitFeatures::TestQgsMapToolSplitFeatures() = default;
+
+
+//runs before all tests
+void TestQgsMapToolSplitFeatures::initTestCase()
+{
+  QgsApplication::init();
+  QgsApplication::initQgis();
+
+  mQgisApp = new QgisApp();
+
+  mCanvas = new QgsMapCanvas();
+  mCanvas->setDestinationCrs( QgsCoordinateReferenceSystem( QStringLiteral( "EPSG:3946" ) ) );
+
+  // make testing layers
+  mMultiLineStringLayer = new QgsVectorLayer( QStringLiteral( "MultiLineString?crs=EPSG:3946" ), QStringLiteral( "layer multiline" ), QStringLiteral( "memory" ) );
+  QVERIFY( mMultiLineStringLayer->isValid() );
+  mMultiLineStringLayer->startEditing();
+  lineF1.setGeometry( QgsGeometry::fromWkt( QStringLiteral( "MultiLineString ((0 0, 10 0))" ) ) );
+  lineF2.setGeometry( QgsGeometry::fromWkt( QStringLiteral( "MultiLineString ((0 5, 10 5),(10 5, 15 5))" ) ) );
+  mMultiLineStringLayer->addFeature( lineF1 );
+  mMultiLineStringLayer->addFeature( lineF2 );
+
+  mPolygonLayer = new QgsVectorLayer( QStringLiteral( "Polygon?crs=EPSG:3946" ), QStringLiteral( "layer polygon" ), QStringLiteral( "memory" ) );
+  QVERIFY( mPolygonLayer->isValid() );
+  mPolygonLayer->startEditing();
+  polygonF1.setGeometry( QgsGeometry::fromWkt( QStringLiteral( "Polygon ((0 5, 0 10, 10 10, 10 5, 0 5))" ) ) );
+  polygonF2.setGeometry( QgsGeometry::fromWkt( QStringLiteral( "Polygon ((0 0, 0 5, 10 5, 10 0, 0 0))" ) ) );
+  mPolygonLayer->addFeature( polygonF1 );
+  mPolygonLayer->addFeature( polygonF2 );
+
+  mMultiPolygonLayer = new QgsVectorLayer( QStringLiteral( "MultiPolygon?crs=EPSG:3946" ), QStringLiteral( "layer multipolygon" ), QStringLiteral( "memory" ) );
+  QVERIFY( mMultiPolygonLayer->isValid() );
+  mMultiPolygonLayer->startEditing();
+  multipolygonF1.setGeometry( QgsGeometry::fromWkt( QStringLiteral( "MultiPolygon (((0 5, 0 10, 10 10, 10 5, 0 5)),((0 0, 0 4, 10 4, 10 0, 0 0)))" ) ) );
+  mMultiPolygonLayer->addFeature( multipolygonF1 );
+
+  mCanvas->setFrameStyle( QFrame::NoFrame );
+  mCanvas->resize( 50, 50 );
+  mCanvas->setExtent( QgsRectangle( 0, 0, 10, 10 ) );
+  mCanvas->show(); // to make the canvas resize
+  mCanvas->hide();
+  // Disable flaky tests on windows...
+  // QCOMPARE( mCanvas->mapSettings().outputSize(), QSize( 50, 50 ) );
+  // QCOMPARE( mCanvas->mapSettings().visibleExtent(), QgsRectangle( 0, 0, 10, 10 ) );
+
+  QgsProject::instance()->addMapLayers( QList<QgsMapLayer *>() << mMultiLineStringLayer
+                                        << mPolygonLayer
+                                        << mMultiPolygonLayer );
+
+  // set layers in canvas
+  mCanvas->setLayers( QList<QgsMapLayer *>() << mMultiLineStringLayer
+                      << mPolygonLayer
+                      << mMultiPolygonLayer );
+
+}
+
+void TestQgsMapToolSplitFeatures::cleanupTestCase()
+{
+  QgsApplication::exitQgis();
+}
+
+QPoint TestQgsMapToolSplitFeatures::mapToPoint( double x, double y )
+{
+
+  QgsPointXY mapPoint = mCanvas->mapSettings().mapToPixel().transform( x, y );
+
+  return QPoint( std::round( mapPoint.x() ), std::round( mapPoint.y() ) );
+}
+
+void TestQgsMapToolSplitFeatures::testNoFeaturesSplit()
+{
+  mCanvas->setCurrentLayer( mMultiLineStringLayer );
+  QgsMapToolSplitFeatures *mapTool = new QgsMapToolSplitFeatures( mCanvas ) ;
+  mCanvas->setMapTool( mapTool );
+
+  std::unique_ptr< QgsMapMouseEvent > event( new QgsMapMouseEvent(
+        mCanvas,
+        QEvent::MouseButtonRelease,
+        mapToPoint( 4, 7 ),
+        Qt::LeftButton
+      ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+  event.reset( new QgsMapMouseEvent(
+                 mCanvas,
+                 QEvent::MouseButtonRelease,
+                 mapToPoint( 4, 8 ),
+                 Qt::LeftButton
+               ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+
+  event.reset( new QgsMapMouseEvent(
+                 mCanvas,
+                 QEvent::MouseButtonRelease,
+                 mapToPoint( 4, 8 ),
+                 Qt::RightButton
+               ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+
+
+  QCOMPARE( mMultiLineStringLayer->featureCount(), 2 );
+//  This is not working as expected: count is always 1, see https://github.com/qgis/QGIS/issues/38287
+//  QCOMPARE( mMultiLineStringLayer->undoStack()->count(), 0 );
+  mMultiLineStringLayer->undoStack()->undo();
+}
+
+void TestQgsMapToolSplitFeatures::testSplitPolygon()
+{
+  QgsProject::instance()->setTopologicalEditing( false );
+  mCanvas->setCurrentLayer( mPolygonLayer );
+  QgsMapToolSplitFeatures *mapTool = new QgsMapToolSplitFeatures( mCanvas ) ;
+  mCanvas->setMapTool( mapTool );
+
+  std::unique_ptr< QgsMapMouseEvent > event( new QgsMapMouseEvent(
+        mCanvas,
+        QEvent::MouseButtonRelease,
+        mapToPoint( 4, 11 ),
+        Qt::LeftButton
+      ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+  event.reset( new QgsMapMouseEvent(
+                 mCanvas,
+                 QEvent::MouseButtonRelease,
+                 mapToPoint( 4, 3 ),
+                 Qt::LeftButton
+               ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+
+  event.reset( new QgsMapMouseEvent(
+                 mCanvas,
+                 QEvent::MouseButtonRelease,
+                 mapToPoint( 4, 3 ),
+                 Qt::RightButton
+               ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+
+  QCOMPARE( mPolygonLayer->undoStack()->index(), 3 );
+  QCOMPARE( mPolygonLayer->featureCount(), 3 );
+  QCOMPARE( mPolygonLayer->getFeature( polygonF1.id() ).geometry().asWkt(), QStringLiteral( "Polygon ((4 10, 4 5, 0 5, 0 10, 4 10))" ) );
+  QCOMPARE( mPolygonLayer->getFeature( polygonF2.id() ).geometry().asWkt(), QStringLiteral( "Polygon ((0 0, 0 5, 10 5, 10 0, 0 0))" ) );
+
+  // no change to other layers
+  QCOMPARE( mMultiLineStringLayer->undoStack()->index(), 2 );
+  QCOMPARE( mMultiPolygonLayer->undoStack()->index(), 1 );
+
+  // undo changes
+  mPolygonLayer->undoStack()->undo();
+  QCOMPARE( mPolygonLayer->undoStack()->index(), 2 );
+}
+
+void TestQgsMapToolSplitFeatures::testSplitPolygonTopologicalEditing()
+{
+  QgsProject::instance()->setTopologicalEditing( true );
+  mCanvas->setCurrentLayer( mPolygonLayer );
+  QgsMapToolSplitFeatures *mapTool = new QgsMapToolSplitFeatures( mCanvas ) ;
+  mCanvas->setMapTool( mapTool );
+
+  std::unique_ptr< QgsMapMouseEvent > event( new QgsMapMouseEvent(
+        mCanvas,
+        QEvent::MouseButtonRelease,
+        mapToPoint( 4, 11 ),
+        Qt::LeftButton
+      ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+  event.reset( new QgsMapMouseEvent(
+                 mCanvas,
+                 QEvent::MouseButtonRelease,
+                 mapToPoint( 4, 3 ),
+                 Qt::LeftButton
+               ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+
+  event.reset( new QgsMapMouseEvent(
+                 mCanvas,
+                 QEvent::MouseButtonRelease,
+                 mapToPoint( 4, 3 ),
+                 Qt::RightButton
+               ) );
+  mapTool->cadCanvasReleaseEvent( event.get() );
+
+  QCOMPARE( mPolygonLayer->undoStack()->index(), 3 );
+  QCOMPARE( mPolygonLayer->featureCount(), 3 );
+  QCOMPARE( mPolygonLayer->getFeature( polygonF1.id() ).geometry().asWkt(), QStringLiteral( "Polygon ((4 10, 4 5, 0 5, 0 10, 4 10))" ) );
+  QCOMPARE( mPolygonLayer->getFeature( polygonF2.id() ).geometry().asWkt(), QStringLiteral( "Polygon ((0 0, 0 5, 4 5, 10 5, 10 0, 0 0))" ) );
+
+  QCOMPARE( mMultiLineStringLayer->undoStack()->index(), 3 );
+  QCOMPARE( mMultiLineStringLayer->getFeature( lineF2.id() ).geometry().asWkt(), QStringLiteral( "MultiLineString ((0 5, 4 5, 10 5),(10 5, 15 5))" ) );
+  QCOMPARE( mMultiPolygonLayer->undoStack()->index(), 2 );
+  QCOMPARE( mMultiPolygonLayer->getFeature( multipolygonF1.id() ).geometry().asWkt(), QStringLiteral( "MultiPolygon (((0 5, 0 10, 4 10, 10 10, 10 5, 4 5, 0 5)),((0 0, 0 4, 10 4, 10 0, 0 0)))" ) );
+
+  // undo changes
+  mPolygonLayer->undoStack()->undo();
+  QCOMPARE( mPolygonLayer->undoStack()->index(), 2 );
+  mMultiLineStringLayer->undoStack()->undo();
+  QCOMPARE( mMultiLineStringLayer->undoStack()->index(), 2 );
+  mMultiPolygonLayer->undoStack()->undo();
+  QCOMPARE( mMultiPolygonLayer->undoStack()->index(), 1 );
+}
+
+QGSTEST_MAIN( TestQgsMapToolSplitFeatures )
+#include "testqgsmaptoolsplitfeatures.moc"